From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH] xen: domain_update_node_affinity: Correct the ASSERT Date: Mon, 28 Jul 2014 19:25:19 +0200 Message-ID: <1406568319.4038.17.camel@Solace> References: <1406302204-13992-1-git-send-email-julien.grall@linaro.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0573465602938895329==" Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1XBofu-0006lA-Tb for xen-devel@lists.xenproject.org; Mon, 28 Jul 2014 17:25:27 +0000 In-Reply-To: <1406302204-13992-1-git-send-email-julien.grall@linaro.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Julien Grall Cc: Juergen Gross , Keir Fraser , ian.campbell@citrix.com, Ian Jackson , tim@xen.org, George Dunlap , stefano.stabellini@citrix.com, Jan Beulich , xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org --===============0573465602938895329== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-VPQFeJTJunDd3WDhtsSw" --=-VPQFeJTJunDd3WDhtsSw Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On ven, 2014-07-25 at 16:30 +0100, Julien Grall wrote: > The commit "move domain to cpupool0 before destroying it" make Xen crashe= s > when a domain is destroyed with d->vcpus allocated but no VCPU initialize= d. >=20 The title of the commit is certainly useful. Perhaps the beginning of the hash would have been too. > Assertion '!cpumask_empty(dom_cpumask)' failed at domain.c:452 > Xen call trace: > [<00207bd8>] domain_update_node_affinity+0x10c/0x238 (PC) > [<00000004>] 00000004 (LR) > [<00226870>] sched_move_domain+0x3cc/0x42c > [<0020925c>] domain_kill+0xc8/0x178 > [<00206a0c>] do_domctl+0xaac/0x15e4 > [<002529c0>] do_trap_hypervisor+0xc5c/0xf94 > [<002559f0>] return_from_trap+0/0x4 >=20 > Fix the ASSERT to check if d->vcpu is allocated and VCPU 0 is initialized= . >=20 > Signed-off-by: Julien Grall > Cc: George Dunlap > Cc: Dario Faggioli > Cc: Juergen Gross > Cc: Ian Campbell > Cc: Ian Jackson > Cc: Jan Beulich > Cc: Keir Fraser > Cc: Tim Deegan >=20 In any case: Reviewed-by: Dario Faggioli --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-VPQFeJTJunDd3WDhtsSw Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEABECAAYFAlPWh38ACgkQk4XaBE3IOsQSSgCfUFE85TRGxSHTouEZHSUDbk+5 6jcAn3oHdnHkbXbVtQr33DIhYbhVqutE =AjLl -----END PGP SIGNATURE----- --=-VPQFeJTJunDd3WDhtsSw-- --===============0573465602938895329== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============0573465602938895329==--