* [PATCH v2] x86/cpu: Drop the num_siblings check against nr_cpu_ids
@ 2014-07-29 16:35 Andrew Cooper
0 siblings, 0 replies; only message in thread
From: Andrew Cooper @ 2014-07-29 16:35 UTC (permalink / raw)
To: Xen-devel; +Cc: Andrew Cooper, Jan Beulich
The printk() is missing a newline which resulted in console corruption.
However, nr_cpu_ids can be legitimately lower than valid num_sibling values
given certain compile or boot time configuration.
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
CC: Jan Beulich <JBeulich@suse.com>
---
v2: Drop the entire clause. It is bogus
---
xen/arch/x86/cpu/common.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/xen/arch/x86/cpu/common.c b/xen/arch/x86/cpu/common.c
index 5156df3..b3af1ae 100644
--- a/xen/arch/x86/cpu/common.c
+++ b/xen/arch/x86/cpu/common.c
@@ -444,12 +444,6 @@ void __cpuinit detect_ht(struct cpuinfo_x86 *c)
printk(KERN_INFO "CPU: Hyper-Threading is disabled\n");
} else if (c->x86_num_siblings > 1 ) {
- if (c->x86_num_siblings > nr_cpu_ids) {
- printk(KERN_WARNING "CPU: Unsupported number of the siblings %d", c->x86_num_siblings);
- c->x86_num_siblings = 1;
- return;
- }
-
index_msb = get_count_order(c->x86_num_siblings);
c->phys_proc_id = phys_pkg_id((ebx >> 24) & 0xFF, index_msb);
--
1.7.10.4
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2014-07-29 16:35 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-29 16:35 [PATCH v2] x86/cpu: Drop the num_siblings check against nr_cpu_ids Andrew Cooper
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).