From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: [PATCH v2] x86/cpu: Drop the num_siblings check against nr_cpu_ids Date: Tue, 29 Jul 2014 17:35:36 +0100 Message-ID: <1406651736-15551-1-git-send-email-andrew.cooper3@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Xen-devel Cc: Andrew Cooper , Jan Beulich List-Id: xen-devel@lists.xenproject.org The printk() is missing a newline which resulted in console corruption. However, nr_cpu_ids can be legitimately lower than valid num_sibling values given certain compile or boot time configuration. Signed-off-by: Andrew Cooper CC: Jan Beulich --- v2: Drop the entire clause. It is bogus --- xen/arch/x86/cpu/common.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/xen/arch/x86/cpu/common.c b/xen/arch/x86/cpu/common.c index 5156df3..b3af1ae 100644 --- a/xen/arch/x86/cpu/common.c +++ b/xen/arch/x86/cpu/common.c @@ -444,12 +444,6 @@ void __cpuinit detect_ht(struct cpuinfo_x86 *c) printk(KERN_INFO "CPU: Hyper-Threading is disabled\n"); } else if (c->x86_num_siblings > 1 ) { - if (c->x86_num_siblings > nr_cpu_ids) { - printk(KERN_WARNING "CPU: Unsupported number of the siblings %d", c->x86_num_siblings); - c->x86_num_siblings = 1; - return; - } - index_msb = get_count_order(c->x86_num_siblings); c->phys_proc_id = phys_pkg_id((ebx >> 24) & 0xFF, index_msb); -- 1.7.10.4