From mboxrd@z Thu Jan 1 00:00:00 1970 From: Don Slutz Subject: [PATCH v2 2/2] xen/console: Better handing of console_timestamps as a boolean_param Date: Tue, 29 Jul 2014 15:57:49 -0400 Message-ID: <1406663869-31522-3-git-send-email-dslutz@verizon.com> References: <1406663869-31522-1-git-send-email-dslutz@verizon.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1406663869-31522-1-git-send-email-dslutz@verizon.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: xen-devel@lists.xen.org Cc: Keir Fraser , Ian Campbell , Andrew Cooper , Ian Jackson , Don Slutz , Tim Deegan , Jan Beulich List-Id: xen-devel@lists.xenproject.org In order to handle all the old ways, change to use parse_bool(). Signed-off-by: Don Slutz --- v2: Drop stacked inversions part of patch. xen/drivers/char/console.c | 26 ++++++++++++++++++-------- 1 file changed, 18 insertions(+), 8 deletions(-) diff --git a/xen/drivers/char/console.c b/xen/drivers/char/console.c index 2f6c090..4f473e3 100644 --- a/xen/drivers/char/console.c +++ b/xen/drivers/char/console.c @@ -559,15 +559,25 @@ static int printk_prefix_check(char *p, char **pp) static void __init parse_console_timestamps(char *s) { - if ( *s == '\0' || /* Compat for old booleanparam() */ - !strcmp(s, "date") ) - opt_con_timestamp_mode = TSM_DATE; - else if ( !strcmp(s, "datems") ) - opt_con_timestamp_mode = TSM_DATE_MS; - else if ( !strcmp(s, "boot") ) - opt_con_timestamp_mode = TSM_BOOT; - else if ( !strcmp(s, "none") ) + switch ( parse_bool(s) ) + { + case 0: opt_con_timestamp_mode = TSM_NONE; + break; + case 1: + opt_con_timestamp_mode = TSM_DATE; + break; + default: + if ( *s == '\0' || /* Compat for old booleanparam() */ + !strcmp(s, "date") ) + opt_con_timestamp_mode = TSM_DATE; + else if ( !strcmp(s, "datems") ) + opt_con_timestamp_mode = TSM_DATE_MS; + else if ( !strcmp(s, "boot") ) + opt_con_timestamp_mode = TSM_BOOT; + else if ( !strcmp(s, "none") ) + opt_con_timestamp_mode = TSM_NONE; + } } static void printk_start_of_line(const char *prefix) -- 1.8.4