xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Tiejun Chen <tiejun.chen@intel.com>
To: JBeulich@suse.com, yang.z.zhang@intel.com, kevin.tian@intel.com
Cc: xen-devel@lists.xen.org
Subject: [v6][PATCH 1/2] xen:x86:mm:p2m: introduce set_identity_p2m_entry
Date: Wed, 30 Jul 2014 09:36:25 +0800	[thread overview]
Message-ID: <1406684186-12788-1-git-send-email-tiejun.chen@intel.com> (raw)

Its used conveniently to create RMRR mapping in shared EPT case.

Signed-off-by: Tiejun Chen <tiejun.chen@intel.com>
---
 xen/arch/x86/mm/p2m.c     | 29 +++++++++++++++++++++++++++++
 xen/include/asm-x86/p2m.h |  3 +++
 2 files changed, 32 insertions(+)

v6:

* Refactor set_identity_p2m_entry to make sense

v5:

* Rename this function as set_identity_p2m_entry()
* Get mfn directly inside set_identity_p2m_entry()

v4:

* new patch to combine get and set together to create RMRR mapping.

diff --git a/xen/arch/x86/mm/p2m.c b/xen/arch/x86/mm/p2m.c
index 642ec28..06bed7a 100644
--- a/xen/arch/x86/mm/p2m.c
+++ b/xen/arch/x86/mm/p2m.c
@@ -858,6 +858,35 @@ int set_mmio_p2m_entry(struct domain *d, unsigned long gfn, mfn_t mfn)
     return set_typed_p2m_entry(d, gfn, mfn, p2m_mmio_direct);
 }
 
+int set_identity_p2m_entry(struct domain *d, unsigned long gfn)
+{
+    p2m_type_t p2mt;
+    p2m_access_t a;
+    mfn_t mfn;
+    struct p2m_domain *p2m = p2m_get_hostp2m(d);
+    int ret = -EBUSY;
+
+    gfn_lock(p2m, gfn, 0);
+
+    mfn = p2m->get_entry(p2m, gfn, &p2mt, &a, 0, NULL);
+
+    if ( !mfn_valid(mfn) )
+        ret = p2m_set_entry(p2m, gfn, _mfn(gfn), PAGE_ORDER_4K, p2m_mmio_direct,
+                            p2m_access_rw);
+    else if ( mfn_x(mfn) == gfn &&
+              p2mt == p2m_mmio_direct &&
+              a == p2m_access_rw )
+        ret = 0;
+    else
+        printk(XENLOG_G_WARNING
+               "Cannot identity map d%d:%lx, already mapped to %lx.\n",
+               d->domain_id, gfn, mfn_x(mfn));
+
+    gfn_unlock(p2m, gfn, 0);
+
+    return ret;
+}
+
 /* Returns: 0 for success, -errno for failure */
 int clear_mmio_p2m_entry(struct domain *d, unsigned long gfn)
 {
diff --git a/xen/include/asm-x86/p2m.h b/xen/include/asm-x86/p2m.h
index 0ddbadb..d130f9a 100644
--- a/xen/include/asm-x86/p2m.h
+++ b/xen/include/asm-x86/p2m.h
@@ -536,6 +536,9 @@ int p2m_is_logdirty_range(struct p2m_domain *, unsigned long start,
 int set_mmio_p2m_entry(struct domain *d, unsigned long gfn, mfn_t mfn);
 int clear_mmio_p2m_entry(struct domain *d, unsigned long gfn);
 
+/* Set identity addresses in the p2m table (for pass-through) */
+int set_identity_p2m_entry(struct domain *d, unsigned long gfn);
+
 /* Add foreign mapping to the guest's p2m table. */
 int p2m_add_foreign(struct domain *tdom, unsigned long fgfn,
                     unsigned long gpfn, domid_t foreign_domid);
-- 
1.9.1

             reply	other threads:[~2014-07-30  1:36 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-30  1:36 Tiejun Chen [this message]
2014-07-30  1:36 ` [v6][PATCH 2/2] xen:vtd: missing RMRR mapping while share EPT Tiejun Chen
2014-07-30  8:36   ` Jan Beulich
2014-07-30  8:59     ` Chen, Tiejun
2014-07-30  9:23       ` Jan Beulich
2014-07-30  9:40         ` Chen, Tiejun
2014-07-30 10:25           ` Jan Beulich
2014-07-30 10:40             ` Chen, Tiejun
2014-07-30 10:47               ` Jan Beulich
2014-07-31  9:45                 ` Chen, Tiejun
2014-07-31 22:44                   ` Tian, Kevin
2014-08-01  2:07                     ` Chen, Tiejun
2014-08-01  6:51                   ` Jan Beulich
2014-08-01  7:10                     ` Chen, Tiejun
2014-08-01  7:21                       ` Jan Beulich
2014-08-01  9:50                         ` Chen, Tiejun
2014-08-01 13:47                           ` Jan Beulich
2014-08-01 23:22                             ` Tian, Kevin
2014-08-04  7:23                               ` Jan Beulich
2014-08-03  8:04                             ` Chen, Tiejun
2014-08-04  7:31                               ` Jan Beulich
2014-08-07 10:59                                 ` Chen, Tiejun
2014-09-03  9:41                                 ` Chen, Tiejun
2014-09-03  9:54                                   ` Jan Beulich
2014-09-12  6:38                                     ` Chen, Tiejun
2014-09-12  7:19                                       ` Jan Beulich
2014-09-12  8:27                                         ` Chen, Tiejun
2014-09-12 16:59                                           ` Lars Kurth
2014-09-12 21:26                                             ` Tim Deegan
2014-09-16  1:24                                               ` Chen, Tiejun
2014-09-17  1:01                                                 ` Chen, Tiejun
2014-09-17  2:42                                                   ` Tian, Kevin
2014-09-17  9:21                                                     ` Jan Beulich
2014-09-18  2:02                                                       ` Zhang, Yang Z
2014-09-18  7:24                                                         ` Jan Beulich
2014-09-18  7:41                                                           ` Zhang, Yang Z
2014-09-18  8:12                                                             ` Jan Beulich
2014-09-17  9:18                                                   ` Jan Beulich
2014-09-18  9:09   ` Jan Beulich
2014-09-19  1:20     ` Chen, Tiejun
2014-09-19  6:26       ` Jan Beulich
2014-09-19  6:50         ` Chen, Tiejun
2014-09-19  7:10           ` Jan Beulich
2014-09-19  7:40             ` Chen, Tiejun
2014-09-19  8:06               ` Jan Beulich
2014-09-19  8:30                 ` Chen, Tiejun
2014-09-19  9:26                   ` Jan Beulich
2014-09-19  2:43     ` Zhang, Yang Z
2014-09-19  6:33       ` Jan Beulich
2014-07-31 22:29 ` [v6][PATCH 1/2] xen:x86:mm:p2m: introduce set_identity_p2m_entry Tian, Kevin
2014-08-01  2:25   ` Chen, Tiejun
2014-08-01  6:43     ` Jan Beulich
2014-08-01  6:42   ` Jan Beulich
2014-08-01 15:56     ` Tian, Kevin
  -- strict thread matches above, loose matches on Subject: below --
2014-07-30  1:26 Tiejun Chen
2014-07-30  1:32 ` Chen, Tiejun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1406684186-12788-1-git-send-email-tiejun.chen@intel.com \
    --to=tiejun.chen@intel.com \
    --cc=JBeulich@suse.com \
    --cc=kevin.tian@intel.com \
    --cc=xen-devel@lists.xen.org \
    --cc=yang.z.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).