From: Ian Campbell <Ian.Campbell@citrix.com>
To: Julien Grall <julien.grall@linaro.org>
Cc: stefano.stabellini@eu.citrix.com, tim@xen.org, xen-devel@lists.xen.org
Subject: Re: [PATCH] xen: arm: Write to the correct PT when mapping the DTB on boot on arm64
Date: Mon, 4 Aug 2014 15:01:53 +0100 [thread overview]
Message-ID: <1407160913.16946.5.camel@kazak.uk.xensource.com> (raw)
In-Reply-To: <53D249C6.70204@linaro.org>
On Fri, 2014-07-25 at 13:12 +0100, Julien Grall wrote:
> On 07/25/2014 10:32 AM, Ian Campbell wrote:
> > We currently get away with this because when debug=y and earlyprintk is enabled
> > the previous block of (conditinal) code would have set this up. Historically we
>
> NIT: conditional
Fixed.
> > mostly got away with it even without those options because the pre paging code
> > would normally (at least on h/w we test) leave x4 set to the paddr of
> > boot_second.
> >
> > This latent bug has always been present but was exposed by ca59618967fe "xen:
> > arm: Handle 4K aligned hypervisor load address" (or one of the related patches)
> > since now x4 is quite likely to point to boot_third not boot_second.
> >
> > Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
>
> Acked-by: Julien Grall <julien.grall@linaro.org>
Applied, thanks.
prev parent reply other threads:[~2014-08-04 14:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-25 9:32 [PATCH] xen: arm: Write to the correct PT when mapping the DTB on boot on arm64 Ian Campbell
2014-07-25 12:12 ` Julien Grall
2014-08-04 14:01 ` Ian Campbell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1407160913.16946.5.camel@kazak.uk.xensource.com \
--to=ian.campbell@citrix.com \
--cc=julien.grall@linaro.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).