From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH] xen: arm: Write to the correct PT when mapping the DTB on boot on arm64 Date: Mon, 4 Aug 2014 15:01:53 +0100 Message-ID: <1407160913.16946.5.camel@kazak.uk.xensource.com> References: <53D249C6.70204@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <53D249C6.70204@linaro.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Julien Grall Cc: stefano.stabellini@eu.citrix.com, tim@xen.org, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Fri, 2014-07-25 at 13:12 +0100, Julien Grall wrote: > On 07/25/2014 10:32 AM, Ian Campbell wrote: > > We currently get away with this because when debug=y and earlyprintk is enabled > > the previous block of (conditinal) code would have set this up. Historically we > > NIT: conditional Fixed. > > mostly got away with it even without those options because the pre paging code > > would normally (at least on h/w we test) leave x4 set to the paddr of > > boot_second. > > > > This latent bug has always been present but was exposed by ca59618967fe "xen: > > arm: Handle 4K aligned hypervisor load address" (or one of the related patches) > > since now x4 is quite likely to point to boot_third not boot_second. > > > > Signed-off-by: Ian Campbell > > Acked-by: Julien Grall Applied, thanks.