From: Tiejun Chen <tiejun.chen@intel.com>
To: JBeulich@suse.com, ian.jackson@eu.citrix.com,
stefano.stabellini@eu.citrix.com, ian.campbell@citrix.com,
yang.z.zhang@intel.com, kevin.tian@intel.com
Cc: xen-devel@lists.xen.org
Subject: [RFC][PATCH 3/5] tools:libxc: remove mmio BAR out of RMRR mappings
Date: Thu, 7 Aug 2014 19:02:49 +0800 [thread overview]
Message-ID: <1407409371-31728-4-git-send-email-tiejun.chen@intel.com> (raw)
In-Reply-To: <1407409371-31728-1-git-send-email-tiejun.chen@intel.com>
We need to avoid allocating MMIO BAR conficting to RMRR range.
Signed-off-by: Tiejun Chen <tiejun.chen@intel.com>
---
tools/libxc/xc_domain.c | 25 +++++++++++++++++++++++++
tools/libxc/xc_hvm_build_x86.c | 26 ++++++++++++++++++++++++++
tools/libxc/xenctrl.h | 4 ++++
3 files changed, 55 insertions(+)
diff --git a/tools/libxc/xc_domain.c b/tools/libxc/xc_domain.c
index 0230c6c..c1dddb1 100644
--- a/tools/libxc/xc_domain.c
+++ b/tools/libxc/xc_domain.c
@@ -648,6 +648,31 @@ int xc_domain_set_memory_map(xc_interface *xch,
return rc;
}
+
+int xc_get_rmrr_map(xc_interface *xch,
+ struct e820entry entries[],
+ uint32_t max_entries)
+{
+ int rc;
+ struct xen_memory_map memmap = {
+ .nr_entries = max_entries
+ };
+ DECLARE_HYPERCALL_BOUNCE(entries, sizeof(struct e820entry) * max_entries,
+ XC_HYPERCALL_BUFFER_BOUNCE_OUT);
+
+ if ( !entries || xc_hypercall_bounce_pre(xch, entries) || max_entries <= 1)
+ return -1;
+
+
+ set_xen_guest_handle(memmap.buffer, entries);
+
+ rc = do_memory_op(xch, XENMEM_RMRR_memory_map, &memmap, sizeof(memmap));
+
+ xc_hypercall_bounce_post(xch, entries);
+
+ return rc ? rc : memmap.nr_entries;
+}
+
int xc_get_machine_memory_map(xc_interface *xch,
struct e820entry entries[],
uint32_t max_entries)
diff --git a/tools/libxc/xc_hvm_build_x86.c b/tools/libxc/xc_hvm_build_x86.c
index c81a25b..27d8182 100644
--- a/tools/libxc/xc_hvm_build_x86.c
+++ b/tools/libxc/xc_hvm_build_x86.c
@@ -262,6 +262,8 @@ static int setup_guest(xc_interface *xch,
int claim_enabled = args->claim_enabled;
xen_pfn_t special_array[NR_SPECIAL_PAGES];
xen_pfn_t ioreq_server_array[NR_IOREQ_SERVER_PAGES];
+ struct e820entry map[E820MAX];
+ uint64_t rmrr_end = 0;
if ( nr_pages > target_pages )
pod_mode = XENMEMF_populate_on_demand;
@@ -300,6 +302,30 @@ static int setup_guest(xc_interface *xch,
goto error_out;
}
+ /* We need to move mmio range out of RMRR mapping. */
+ rc = xc_get_rmrr_map(xch, map, E820MAX);
+ if (rc < 0)
+ {
+ PERROR("Could not get RMRR info on domain");
+ }
+ else if ( rc )
+ {
+ for ( i = 0; i < rc; i++ )
+ {
+ rmrr_end = map[i].addr + map[i].size + 1;
+ if ( rmrr_end > mmio_start )
+ {
+ mmio_start = rmrr_end;
+ }
+ }
+ mmio_size = (1ull << 32) - mmio_start;
+ if ( mmio_size <= 0 )
+ {
+ PERROR("Could not allocate MMIO memory.");
+ goto error_out;
+ }
+ }
+
for ( i = 0; i < nr_pages; i++ )
page_array[i] = i;
for ( i = mmio_start >> PAGE_SHIFT; i < nr_pages; i++ )
diff --git a/tools/libxc/xenctrl.h b/tools/libxc/xenctrl.h
index 5beb846..14ef42f 100644
--- a/tools/libxc/xenctrl.h
+++ b/tools/libxc/xenctrl.h
@@ -1270,6 +1270,10 @@ int xc_domain_set_memory_map(xc_interface *xch,
int xc_get_machine_memory_map(xc_interface *xch,
struct e820entry entries[],
uint32_t max_entries);
+
+int xc_get_rmrr_map(xc_interface *xch,
+ struct e820entry entries[],
+ uint32_t max_entries);
#endif
int xc_domain_set_time_offset(xc_interface *xch,
uint32_t domid,
--
1.9.1
next prev parent reply other threads:[~2014-08-07 11:02 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-07 11:02 [RFC][PATCH 0/5] xen: reserve RMRR to avoid conflicting MMIO/RAM Tiejun Chen
2014-08-07 11:02 ` [RFC][PATCH 1/5] xen:x86: record RMRR mappings Tiejun Chen
2014-08-08 15:36 ` Jan Beulich
2014-08-11 3:04 ` Chen, Tiejun
2014-08-11 6:51 ` Jan Beulich
2014-08-11 7:00 ` Chen, Tiejun
2014-08-11 8:42 ` Jan Beulich
2014-08-07 11:02 ` [RFC][PATCH 2/5] xen:x86: introduce a new hypercall to get " Tiejun Chen
2014-08-08 15:45 ` Jan Beulich
2014-08-12 10:55 ` Chen, Tiejun
2014-08-12 12:19 ` Jan Beulich
2014-08-13 0:40 ` Chen, Tiejun
2014-08-13 18:21 ` Tian, Kevin
2014-08-14 1:07 ` Chen, Tiejun
2014-08-14 16:51 ` Jan Beulich
2014-08-15 6:13 ` Chen, Tiejun
2014-08-07 11:02 ` Tiejun Chen [this message]
2014-08-08 15:49 ` [RFC][PATCH 3/5] tools:libxc: remove mmio BAR out of " Jan Beulich
2014-08-08 21:33 ` Tian, Kevin
2014-08-12 10:56 ` Chen, Tiejun
2014-08-12 12:21 ` Jan Beulich
2014-08-12 10:55 ` Chen, Tiejun
2014-08-07 11:02 ` [RFC][PATCH 4/5] tools:firmware:hvmloader: reserve RMRR mappings in e820 Tiejun Chen
2014-08-07 12:03 ` Andrew Cooper
2014-08-08 2:11 ` Chen, Tiejun
2014-08-08 6:42 ` Jan Beulich
2014-08-08 7:30 ` Chen, Tiejun
2014-08-08 7:43 ` Jan Beulich
2014-08-08 8:39 ` Chen, Tiejun
2014-08-08 9:01 ` Jan Beulich
2014-08-08 9:28 ` Chen, Tiejun
2014-08-08 15:53 ` Jan Beulich
2014-08-08 15:58 ` Andrew Cooper
2014-08-11 6:48 ` Jan Beulich
2014-08-12 7:59 ` Chen, Tiejun
2014-08-08 21:47 ` Tian, Kevin
2014-08-11 6:53 ` Jan Beulich
2014-08-11 16:00 ` Tian, Kevin
2014-08-12 10:59 ` Chen, Tiejun
2014-08-12 12:25 ` Jan Beulich
2014-08-13 0:57 ` Chen, Tiejun
2014-08-13 19:10 ` Tian, Kevin
2014-08-14 3:03 ` Chen, Tiejun
2014-08-14 23:11 ` Tian, Kevin
2014-08-15 8:21 ` Chen, Tiejun
2014-08-12 10:56 ` Chen, Tiejun
2014-08-12 12:22 ` Jan Beulich
2014-08-12 10:56 ` Chen, Tiejun
2014-08-07 11:02 ` [RFC][PATCH 5/5] xen:vtd: make USB RMRR mapping safe Tiejun Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1407409371-31728-4-git-send-email-tiejun.chen@intel.com \
--to=tiejun.chen@intel.com \
--cc=JBeulich@suse.com \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=kevin.tian@intel.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
--cc=yang.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).