xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Wen Congyang <wency@cn.fujitsu.com>
To: xen devel <xen-devel@lists.xen.org>
Cc: Ian Campbell <Ian.Campbell@citrix.com>,
	Wen Congyang <wency@cn.fujitsu.com>,
	Ian Jackson <Ian.Jackson@eu.citrix.com>,
	Jiang Yunhong <yunhong.jiang@intel.com>,
	Dong Eddie <eddie.dong@intel.com>,
	Shriram Rajagopalan <rshriram@cs.ubc.ca>,
	Yang Hongyang <yanghy@cn.fujitsu.com>,
	Lai Jiangshan <laijs@cn.fujitsu.com>
Subject: [RFC Patch v2 14/17] pass correct file to qemu if we use blktap2
Date: Fri, 8 Aug 2014 16:10:55 +0800	[thread overview]
Message-ID: <1407485458-23213-21-git-send-email-wency@cn.fujitsu.com> (raw)
In-Reply-To: <1407485458-23213-1-git-send-email-wency@cn.fujitsu.com>

If we use blktap2, the correct file should be blktap device
not the pdev_path.

Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
Cc: Shriram Rajagopalan <rshriram@cs.ubc.ca>
---
 tools/libxl/libxl_dm.c | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c
index addacdb..d86ce15 100644
--- a/tools/libxl/libxl_dm.c
+++ b/tools/libxl/libxl_dm.c
@@ -680,6 +680,7 @@ static char ** libxl__build_device_model_args_new(libxl__gc *gc,
                 libxl__device_disk_dev_number(disks[i].vdev, &disk, &part);
             const char *format = qemu_disk_format_string(disks[i].format);
             char *drive;
+            const char *pdev_path;
 
             if (dev_number == -1) {
                 LIBXL__LOG(ctx, LIBXL__LOG_WARNING, "unable to determine"
@@ -709,6 +710,12 @@ static char ** libxl__build_device_model_args_new(libxl__gc *gc,
                     continue;
                 }
 
+                if (disks[i].backend == LIBXL_DISK_BACKEND_TAP)
+                    pdev_path = libxl__blktap_devpath(gc, disks[i].pdev_path,
+                                                      disks[i].format);
+                else
+                    pdev_path = disks[i].pdev_path;
+
                 /*
                  * Explicit sd disks are passed through as is.
                  *
@@ -718,11 +725,11 @@ static char ** libxl__build_device_model_args_new(libxl__gc *gc,
                 if (strncmp(disks[i].vdev, "sd", 2) == 0)
                     drive = libxl__sprintf
                         (gc, "file=%s,if=scsi,bus=0,unit=%d,format=%s,cache=writeback",
-                         disks[i].pdev_path, disk, format);
+                         pdev_path, disk, format);
                 else if (disk < 4)
                     drive = libxl__sprintf
                         (gc, "file=%s,if=ide,index=%d,media=disk,format=%s,cache=writeback",
-                         disks[i].pdev_path, disk, format);
+                         pdev_path, disk, format);
                 else
                     continue; /* Do not emulate this disk */
             }
-- 
1.9.3

  parent reply	other threads:[~2014-08-08  8:10 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-08  8:10 [RFC Patch v2 00/17] Some bugfix patches Wen Congyang
2014-08-08  8:10 ` [RFC Patch v2 01/17] copy the correct page to memory Wen Congyang
2014-08-08  8:10 ` [RFC Patch v2 02/17] csum the correct page Wen Congyang
2014-08-08  8:10 ` [RFC Patch v2 03/17] don't zero out ioreq page Wen Congyang
2014-08-08  8:10 ` [RFC Patch v2 04/17] blktap2: dynamic allocate aio_requests to avoid -EBUSY error Wen Congyang
2014-08-08  8:10 ` Wen Congyang
2014-08-08  8:10 ` [RFC Patch v2 05/17] block-remus: fix memory leak Wen Congyang
2014-08-08  8:10 ` Wen Congyang
2014-08-08  8:10 ` [RFC Patch v2 06/17] block-remus: pass uuid to the callback td_open Wen Congyang
2014-08-08  8:10 ` Wen Congyang
2014-08-08  8:10 ` [RFC Patch v2 07/17] blktap2: return the correct dev path Wen Congyang
2014-08-08  8:10 ` Wen Congyang
2014-08-08  8:10 ` [RFC Patch v2 08/17] block-remus: use correct way to get remus_image Wen Congyang
2014-08-08  8:10 ` Wen Congyang
2014-08-08  8:10 ` [RFC Patch v2 09/17] block-remus: fix bug in tdremus_close() Wen Congyang
2014-08-08  8:10 ` Wen Congyang
2014-08-08  8:10 ` [RFC Patch v2 10/17] blktap2: use correct way to get free event id Wen Congyang
2014-08-08  8:10 ` [RFC Patch v2 11/17] blktap2: don't return negative " Wen Congyang
2014-08-08  8:10 ` [RFC Patch v2 12/17] blktap2: use correct way to define array Wen Congyang
2014-08-08  8:10 ` [RFC Patch v2 13/17] don't call client_flush() when switching to unprotected mode Wen Congyang
2014-08-08  8:10 ` Wen Congyang [this message]
2014-08-08  8:10 ` [RFC Patch v2 15/17] support blktap remus in xl Wen Congyang
2014-08-08  8:10 ` [RFC Patch v2 16/17] update libxl__device_disk_from_xs_be() to support blktap device Wen Congyang
2014-08-08  8:44   ` [RFC Patch v2.5 " Wen Congyang
2014-08-08  8:10 ` [RFC Patch v2 17/17] x86/hvm: Always set pending event injection when loading VMC[BS] state Wen Congyang
2014-08-08  8:17 ` [RFC Patch v2 00/17] Some bugfix patches Wen Congyang
  -- strict thread matches above, loose matches on Subject: below --
2014-08-08  8:19 Wen Congyang
2014-08-08  8:20 ` [RFC Patch v2 14/17] pass correct file to qemu if we use blktap2 Wen Congyang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1407485458-23213-21-git-send-email-wency@cn.fujitsu.com \
    --to=wency@cn.fujitsu.com \
    --cc=Ian.Campbell@citrix.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=eddie.dong@intel.com \
    --cc=laijs@cn.fujitsu.com \
    --cc=rshriram@cs.ubc.ca \
    --cc=xen-devel@lists.xen.org \
    --cc=yanghy@cn.fujitsu.com \
    --cc=yunhong.jiang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).