From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wen Congyang Subject: [RFC Patch v2 05/17] block-remus: fix memory leak Date: Fri, 8 Aug 2014 16:10:41 +0800 Message-ID: <1407485458-23213-7-git-send-email-wency@cn.fujitsu.com> References: <1407485458-23213-1-git-send-email-wency@cn.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1407485458-23213-1-git-send-email-wency@cn.fujitsu.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: xen devel Cc: Ian Campbell , Wen Congyang , Ian Jackson , Jiang Yunhong , Dong Eddie , Shriram Rajagopalan , Yang Hongyang , Lai Jiangshan List-Id: xen-devel@lists.xenproject.org Fix the following two memory leak: 1. If s->ramdisk.prev is not NULL, we merge the write requests in s->ramdisk.h into s->ramdisk.prev, and then destroy s->ramdisk.h. But we forget to free hash value when destroying s->ramdisk.h. 2. When write requests is finished, replicated_write_callback() will be called. We forget free the buff in this function. Signed-off-by: Lai Jiangshan Signed-off-by: Jiang Yunhong Signed-off-by: Wen Congyang Cc: Shriram Rajagopalan --- tools/blktap2/drivers/block-remus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/blktap2/drivers/block-remus.c b/tools/blktap2/drivers/block-remus.c index 079588d..4ce9dbe 100644 --- a/tools/blktap2/drivers/block-remus.c +++ b/tools/blktap2/drivers/block-remus.c @@ -602,7 +602,7 @@ static int ramdisk_start_flush(td_driver_t *driver) } free(sectors); - hashtable_destroy (s->ramdisk.h, 0); + hashtable_destroy (s->ramdisk.h, 1); } else s->ramdisk.prev = s->ramdisk.h; -- 1.9.3