From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH v6 10/10] libxl: set vnuma for domain Date: Tue, 12 Aug 2014 19:10:37 +0200 Message-ID: <1407863437.3585.3.camel@Solace> References: <1405662609-31486-1-git-send-email-ufimtseva@gmail.com> <1405662609-31486-11-git-send-email-ufimtseva@gmail.com> <1406630731.23810.15.camel@kazak.uk.xensource.com> <20140812094200.GA16810@zion.uk.xensource.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8050852348041471793==" Return-path: In-Reply-To: <20140812094200.GA16810@zion.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu Cc: Keir Fraser , Ian Campbell , Stefano Stabellini , George Dunlap , Matt Wilson , Li Yechen , Ian Jackson , "xen-devel@lists.xen.org" , Jan Beulich , Elena Ufimtseva List-Id: xen-devel@lists.xenproject.org --===============8050852348041471793== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-SWHM50bHk8z91TMvKl8H" --=-SWHM50bHk8z91TMvKl8H Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On mar, 2014-08-12 at 10:42 +0100, Wei Liu wrote: > On Mon, Aug 11, 2014 at 11:52:55PM -0400, Elena Ufimtseva wrote: > > Preparing the series, I figured that this particular function > > libxl_domain_setvnuma does not have any users. Instead, xc one is > > called directly. > > I want to omit this patch. Do I need to have #define > > LIBXL_HAVE_DOMAIN_SETVNUMA 1 in this case? > >=20 >=20 > If your macro is specifically for this function then you need to remove > macro as well. In this case I think the answer is "no you don't need > that in libxl.h", unless I've mistaken the purpose of your macro. >=20 > Wei. It was something you (Wei) suggested. :-P :-P :-P (Cutting and pasting from http://bugs.xenproject.org/xen/mid/%3C20140718105838.GE7142@zion.uk.xensour= ce.com%3E ) --- > int libxl_fd_set_cloexec(libxl_ctx *ctx, int fd, int cloexec); > int libxl_fd_set_nonblock(libxl_ctx *ctx, int fd, int nonblock); > =20 > +int libxl_domain_setvnuma(libxl_ctx *ctx, > + uint32_t domid, > + uint16_t nr_vnodes, > + uint16_t nr_vcpus, > + vmemrange_t *vmemrange, > + unsigned int *vdistance, > + unsigned int *vcpu_to_vnode, > + unsigned int *vnode_to_pnode); > + > #include > =20 You will need to add #define LIBXL_HAVE_DOMAIN_SETVNUMA 1 to advertise the introduction of new API. Wei. --- Anyway, I agree: if the function goes, no need to add any macro. Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-SWHM50bHk8z91TMvKl8H Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEABECAAYFAlPqSo0ACgkQk4XaBE3IOsTuEwCgjBOIYLEMm4PmlHHlXs9lQNzv XXsAmQGorKdzQ2i+Ik2EivK7Y/x7cYxc =r/i6 -----END PGP SIGNATURE----- --=-SWHM50bHk8z91TMvKl8H-- --===============8050852348041471793== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============8050852348041471793==--