xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Tiejun Chen <tiejun.chen@intel.com>
To: JBeulich@suse.com, ian.jackson@eu.citrix.com,
	stefano.stabellini@eu.citrix.com, ian.campbell@citrix.com,
	yang.z.zhang@intel.com, kevin.tian@intel.com
Cc: xen-devel@lists.xen.org
Subject: [RFC][v3][PATCH 6/6] xen:vtd: make USB RMRR mapping safe
Date: Fri, 15 Aug 2014 16:27:18 +0800	[thread overview]
Message-ID: <1408091238-18364-7-git-send-email-tiejun.chen@intel.com> (raw)
In-Reply-To: <1408091238-18364-1-git-send-email-tiejun.chen@intel.com>

We already reserve all RMRR mappings so USB should be safe with
RMRR.

Signed-off-by: Tiejun Chen <tiejun.chen@intel.com>
---
 xen/drivers/passthrough/vtd/iommu.c | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/xen/drivers/passthrough/vtd/iommu.c b/xen/drivers/passthrough/vtd/iommu.c
index 042b882..319ae05 100644
--- a/xen/drivers/passthrough/vtd/iommu.c
+++ b/xen/drivers/passthrough/vtd/iommu.c
@@ -2273,16 +2273,8 @@ static int intel_iommu_assign_device(
     if ( ret )
         goto done;
 
-    /* FIXME: Because USB RMRR conflicts with guest bios region,
-     * ignore USB RMRR temporarily.
-     */
     seg = pdev->seg;
     bus = pdev->bus;
-    if ( is_usb_device(seg, bus, pdev->devfn) )
-    {
-        ret = 0;
-        goto done;
-    }
 
     /* Setup rmrr identity mapping */
     for_each_rmrr_device( rmrr, bdf, i )
-- 
1.9.1

      parent reply	other threads:[~2014-08-15  8:27 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-15  8:27 [RFC][v3][PATCH 0/6] xen: reserve RMRR to avoid conflicting MMIO/RAM Tiejun Chen
2014-08-15  8:27 ` [RFC][v3][PATCH 1/6] xen:x86: record RMRR mappings Tiejun Chen
2014-08-15  9:39   ` Andrew Cooper
2014-08-15 16:29     ` Jan Beulich
2014-08-18  7:42       ` Chen, Tiejun
2014-08-18  9:57         ` Andrew Cooper
2014-08-18 10:05           ` Chen, Tiejun
2014-08-18 12:31           ` Jan Beulich
2014-08-19  2:14             ` Chen, Tiejun
2014-08-19  2:28               ` Chen, Tiejun
2014-08-19 13:12                 ` Jan Beulich
2014-08-18  7:45     ` Chen, Tiejun
2014-08-18  9:51       ` Andrew Cooper
2014-08-18 10:01         ` Chen, Tiejun
2014-08-18 12:56           ` Jan Beulich
2014-08-15  8:27 ` [RFC][v3][PATCH 2/6] xen:x86: introduce a new hypercall to get " Tiejun Chen
2014-08-15  9:46   ` Andrew Cooper
2014-08-18  7:46     ` Chen, Tiejun
2014-08-15  8:27 ` [RFC][v3][PATCH 3/6] tools:firmware:hvmloader: reserve RMRR mappings in e820 Tiejun Chen
2014-08-15  9:58   ` Andrew Cooper
2014-08-18  7:51     ` Chen, Tiejun
2014-08-18 10:00       ` Andrew Cooper
2014-08-15  8:27 ` [RFC][v3][PATCH 4/6] xen:x86: add XENMEM_reserved_device_memory_map to expose RMRR Tiejun Chen
2014-08-15 12:15   ` Andrew Cooper
2014-08-18  8:00     ` Chen, Tiejun
2014-08-18 10:06       ` Andrew Cooper
2014-08-15  8:27 ` [RFC][v3][PATCH 5/6] tools:libxc: check if mmio BAR is out of RMRR mappings Tiejun Chen
2014-08-15 12:21   ` Andrew Cooper
2014-08-18  8:05     ` Chen, Tiejun
2014-08-15  8:27 ` Tiejun Chen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1408091238-18364-7-git-send-email-tiejun.chen@intel.com \
    --to=tiejun.chen@intel.com \
    --cc=JBeulich@suse.com \
    --cc=ian.campbell@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=kevin.tian@intel.com \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=xen-devel@lists.xen.org \
    --cc=yang.z.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).