From: Ian Campbell <ian.campbell@citrix.com>
To: Suriyan Ramasami <suriyan.r@gmail.com>
Cc: keir@xen.org, julien.grall@linaro.org, tim@xen.org,
xen-devel@lists.xen.org, jbeulich@suse.com,
ian.jackson@citrix.com
Subject: Re: [PATCH v4 1/1] Support Odroid-XU board (Exynos 5410)
Date: Thu, 21 Aug 2014 23:21:23 +0100 [thread overview]
Message-ID: <1408659683.15186.3.camel@citrix.com> (raw)
In-Reply-To: <1408490361-308-1-git-send-email-suriyan.r@gmail.com>
On Tue, 2014-08-19 at 16:19 -0700, Suriyan Ramasami wrote:
> @@ -64,11 +70,11 @@ static int exynos5_specific_mapping(struct domain *d)
> return 0;
> }
>
> -static int __init exynos5_smp_init(void)
> +static int __init exynos_smp_init(paddr_t pa_sysram)
> [...]
> +static int __init exynos5250_smp_init(void)
> [...]
> +static int __init exynos5_smp_init(void)
I'm not sure I grok the intending meaning/distinction of exynos5_* vs
exynos5250_*. It *looks* like you are using exynos5_* for the 5410
specific stuff, but I'm not sure (and I'm half suspecting that you are
using it for both 5410 specific and more general things...).
If that is the case then you really ought to be using exynos5410_* for
stuff which is specific to that chip.
Perhaps exynos5xxx_* would be less confusing for the generic stuff, but
just avoiding using exynos5_* for 5410 specific stuff would be
sufficient.
Ian.
next prev parent reply other threads:[~2014-08-21 22:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-19 23:19 [PATCH v4 1/1] Support Odroid-XU board (Exynos 5410) Suriyan Ramasami
2014-08-21 22:21 ` Ian Campbell [this message]
2014-08-25 21:45 ` Suriyan Ramasami
2014-08-25 22:06 ` Suriyan Ramasami
2014-08-26 17:34 ` Ian Campbell
2014-08-26 21:01 ` Ian Campbell
2014-08-27 19:27 ` Suriyan Ramasami
2014-09-03 10:03 ` Ian Campbell
2014-09-03 17:55 ` Suriyan Ramasami
2014-09-03 18:25 ` Julien Grall
2014-09-03 19:07 ` Suriyan Ramasami
2014-09-03 19:15 ` Julien Grall
[not found] ` <1409821081.15505.44.camel@kazak.uk.xensource.com>
2014-09-04 15:44 ` Suriyan Ramasami
2014-09-04 15:51 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1408659683.15186.3.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=ian.jackson@citrix.com \
--cc=jbeulich@suse.com \
--cc=julien.grall@linaro.org \
--cc=keir@xen.org \
--cc=suriyan.r@gmail.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).