From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH v4 1/1] Support Odroid-XU board (Exynos 5410)
Date: Thu, 21 Aug 2014 23:21:23 +0100
Message-ID: <1408659683.15186.3.camel@citrix.com>
References: <1408490361-308-1-git-send-email-suriyan.r@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1408490361-308-1-git-send-email-suriyan.r@gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Suriyan Ramasami <suriyan.r@gmail.com>
Cc: keir@xen.org, julien.grall@linaro.org, tim@xen.org, xen-devel@lists.xen.org, jbeulich@suse.com, ian.jackson@citrix.com
List-Id: xen-devel@lists.xenproject.org

On Tue, 2014-08-19 at 16:19 -0700, Suriyan Ramasami wrote:
> @@ -64,11 +70,11 @@ static int exynos5_specific_mapping(struct domain *d)
>      return 0;
>  }
>  
> -static int __init exynos5_smp_init(void)
> +static int __init exynos_smp_init(paddr_t pa_sysram)
> [...]

> +static int __init exynos5250_smp_init(void)
> [...]
> +static int __init exynos5_smp_init(void)

I'm not sure I grok the intending meaning/distinction of exynos5_* vs
exynos5250_*. It *looks* like you are using exynos5_* for the 5410
specific stuff, but I'm not sure (and I'm half suspecting that you are
using it for both 5410 specific and more general things...).

If that is the case then you really ought to be using exynos5410_* for
stuff which is specific to that chip.

Perhaps exynos5xxx_* would be less confusing for the generic stuff, but
just avoiding using exynos5_* for 5410 specific stuff would be
sufficient.

Ian.