From: Tiejun Chen <tiejun.chen@intel.com>
To: JBeulich@suse.com, ian.jackson@eu.citrix.com,
stefano.stabellini@eu.citrix.com, ian.campbell@citrix.com,
yang.z.zhang@intel.com, kevin.tian@intel.com,
andrew.cooper3@citrix.com
Cc: xen-devel@lists.xen.org
Subject: [v5][PATCH 05/10] tools:libxc: check if mmio BAR is out of RMRR mappings
Date: Tue, 26 Aug 2014 19:02:55 +0800 [thread overview]
Message-ID: <1409050980-21933-6-git-send-email-tiejun.chen@intel.com> (raw)
In-Reply-To: <1409050980-21933-1-git-send-email-tiejun.chen@intel.com>
We need to avoid allocating MMIO BAR conflicting to RMRR range.
Signed-off-by: Tiejun Chen <tiejun.chen@intel.com>
---
tools/libxc/xc_hvm_build_x86.c | 71 ++++++++++++++++++++++++++++++++++++++++++
1 file changed, 71 insertions(+)
diff --git a/tools/libxc/xc_hvm_build_x86.c b/tools/libxc/xc_hvm_build_x86.c
index c81a25b..612cafa 100644
--- a/tools/libxc/xc_hvm_build_x86.c
+++ b/tools/libxc/xc_hvm_build_x86.c
@@ -239,6 +239,73 @@ static int check_mmio_hole(uint64_t start, uint64_t memsize,
return 1;
}
+/*
+ * Check whether there exists mmio overplap with the specified RMRR
+ * memory range.
+ */
+static int check_rmrr_overlap(xc_interface *xch, uint64_t mmio_start,
+ uint64_t mmio_size)
+{
+ struct xen_mem_reserved_device_memory *map = NULL;
+ uint64_t rmrr_start = 0, rmrr_end = 0;
+ unsigned int i = 0;
+ int rc = 0;
+ /* Assume we have one entry if not enough we'll expand.*/
+ uint32_t nr_entries = 1;
+
+ /* We should check if mmio range is out of RMRR mapping. */
+ if ( (map = malloc(nr_entries *
+ sizeof(xen_mem_reserved_device_memory_t))) == NULL )
+ {
+ PERROR("Could not allocate memory for map.");
+ return -1;
+ }
+ rc = xc_reserved_device_memory_map(xch, map, &nr_entries);
+ if ( rc < 0 )
+ {
+ /* RMRR doesn't exist. */
+ if ( rc == -ENOENT )
+ rc = 0;
+ else if ( rc == -ENOBUFS)
+ {
+ free(map);
+ /* Now we need more space to map all RMRR mappings. */
+ if ( (map = malloc(nr_entries *
+ sizeof(xen_mem_reserved_device_memory_t))) == NULL )
+ {
+ PERROR("Could not allocate memory for map.");
+ return -1;
+ }
+ rc = xc_reserved_device_memory_map(xch, map, &nr_entries);
+ if ( rc < 0 )
+ {
+ PERROR("Could not get RMRR info on domain");
+ free(map);
+ return rc;
+ }
+ }
+ else
+ PERROR("Could not get RMRR info on domain");
+ }
+
+ for ( i = 0; i < rc; i++ )
+ {
+ rmrr_start = map[i].start_pfn << PAGE_SHIFT;
+ rmrr_end = rmrr_start + map[i].nr_pages * PAGE_SIZE;
+ if ( check_mmio_hole(rmrr_start, map[i].nr_pages * PAGE_SIZE,
+ mmio_start, mmio_size) )
+ {
+ PERROR("MMIO: [%lx]<->[%lx] overlap RMRR [%lx]<->[%lx]\n",
+ mmio_start, (mmio_start + mmio_size), rmrr_start, rmrr_end);
+ free(map);
+ return -1;
+ }
+ }
+
+ free(map);
+ return rc;
+}
+
static int setup_guest(xc_interface *xch,
uint32_t dom, struct xc_hvm_build_args *args,
char *image, unsigned long image_size)
@@ -300,6 +367,10 @@ static int setup_guest(xc_interface *xch,
goto error_out;
}
+ rc = check_rmrr_overlap(xch, mmio_start, mmio_start);
+ if ( rc < 0 )
+ goto error_out;
+
for ( i = 0; i < nr_pages; i++ )
page_array[i] = i;
for ( i = mmio_start >> PAGE_SHIFT; i < nr_pages; i++ )
--
1.9.1
next prev parent reply other threads:[~2014-08-26 11:02 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-26 11:02 [v5][PATCH 0/10] xen: reserve RMRR to avoid conflicting MMIO/RAM Tiejun Chen
2014-08-26 11:02 ` [v5][PATCH 01/10] xen:vtd:rmrr: export acpi_rmrr_units Tiejun Chen
2014-08-26 11:02 ` [v5][PATCH 02/10] xen:vtd:rmrr: introduce acpi_rmrr_unit_entries Tiejun Chen
2014-08-26 11:02 ` [v5][PATCH 03/10] xen:x86: define a new hypercall to get RMRR mappings Tiejun Chen
2014-08-26 12:02 ` Andrew Cooper
2014-08-26 12:37 ` Jan Beulich
2014-08-27 1:37 ` Chen, Tiejun
2014-08-27 6:51 ` Jan Beulich
2014-08-27 7:21 ` Chen, Tiejun
2014-08-28 2:24 ` Chen, Tiejun
2014-08-28 6:50 ` Jan Beulich
2014-08-28 7:09 ` Chen, Tiejun
2014-08-28 7:19 ` Chen, Tiejun
2014-08-28 7:29 ` Chen, Tiejun
2014-08-28 7:44 ` Jan Beulich
2014-08-29 3:02 ` Chen, Tiejun
2014-08-29 9:18 ` Jan Beulich
2014-09-01 9:44 ` Chen, Tiejun
2014-09-01 10:29 ` Jan Beulich
2014-09-02 9:59 ` Chen, Tiejun
2014-09-02 10:15 ` Jan Beulich
2014-09-02 11:10 ` Chen, Tiejun
2014-09-02 13:15 ` Jan Beulich
2014-09-03 1:45 ` Chen, Tiejun
2014-09-03 8:31 ` Chen, Tiejun
2014-09-03 8:41 ` Jan Beulich
2014-09-03 8:59 ` Chen, Tiejun
2014-09-03 9:01 ` Chen, Tiejun
2014-09-03 9:54 ` Chen, Tiejun
2014-09-03 12:54 ` Jan Beulich
2014-09-04 1:15 ` Chen, Tiejun
2014-09-03 8:35 ` Jan Beulich
2014-08-27 1:15 ` Chen, Tiejun
2014-09-02 8:25 ` Jan Beulich
2014-08-26 11:02 ` [v5][PATCH 04/10] tools:libxc: introduce hypercall for xc_reserved_device_memory_map Tiejun Chen
2014-08-26 11:02 ` Tiejun Chen [this message]
2014-08-26 11:02 ` [v5][PATCH 06/10] hvm_info_table: introduce nr_reserved_device_memory_map Tiejun Chen
2014-09-02 8:34 ` Jan Beulich
2014-09-04 2:07 ` Chen, Tiejun
2014-09-04 6:32 ` Jan Beulich
2014-09-04 6:55 ` Chen, Tiejun
[not found] ` <54082E3B0200007800030BCB@mail.emea.novell.com>
2014-09-09 6:40 ` Chen, Tiejun
2014-08-26 11:02 ` [v5][PATCH 07/10] xen:x86:: support xc_reserved_device_memory_map in compat case Tiejun Chen
2014-09-02 8:35 ` Jan Beulich
2014-09-04 2:13 ` Chen, Tiejun
2014-08-26 11:02 ` [v5][PATCH 08/10] tools:firmware:hvmloader: introduce hypercall for xc_reserved_device_memory_map Tiejun Chen
2014-09-02 8:37 ` Jan Beulich
2014-08-26 11:02 ` [v5][PATCH 09/10] tools:firmware:hvmloader: check to reserve RMRR mappings in e820 Tiejun Chen
2014-09-02 8:47 ` Jan Beulich
2014-09-04 3:04 ` Chen, Tiejun
2014-09-04 4:32 ` Chen, Tiejun
2014-09-04 6:36 ` Jan Beulich
2014-08-26 11:03 ` [v5][PATCH 10/10] xen:vtd: make USB RMRR mapping safe Tiejun Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1409050980-21933-6-git-send-email-tiejun.chen@intel.com \
--to=tiejun.chen@intel.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=kevin.tian@intel.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
--cc=yang.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).