From: Ian Campbell <ian.campbell@citrix.com>
To: "Aravindh Puthiyaparambil (aravindp)" <aravindp@cisco.com>
Cc: David Scott <dave.scott@eu.citrix.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>,
Andres Lagar Cavilla <andres.lagarcavilla@gmail.com>,
Dushyant Behl <myselfdushyantbehl@gmail.com>
Subject: Re: [PATCH v0 1/3] mem_access: modifications to mem_event enable API.
Date: Tue, 26 Aug 2014 18:50:43 +0100 [thread overview]
Message-ID: <1409075443.28009.15.camel@citrix.com> (raw)
In-Reply-To: <97A500D504438F4ABC02EBA81613CC63318E06E6@xmb-aln-x02.cisco.com>
On Fri, 2014-08-22 at 22:05 +0000, Aravindh Puthiyaparambil (aravindp)
wrote:
> >4. The API xc_mem_event_enable is now modified to return int rather than
> >void *,
> > this was done to synchronize this API's behaviour with other mem_event
> >API's.
>
> FWIW, since I am the one that introduced this... I am fine with the
> change. Though I did think that the norm was to return -1 on error and
> set errno to the appropriate value.
Sadly there isn't really a norm in libxc now, we use basically every
possible way of returning errors.
In so far as we are moving in any particular direction to try and
rationalise this I think we are trying to get to set errno and return -1
(like a normal POSIXy library)
Ian.
next prev parent reply other threads:[~2014-08-26 17:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-13 20:51 [PATCH v0 0/3] Modifications to mem_event_enable API and addition of teardown routine Dushyant Behl
2014-08-13 20:51 ` [PATCH v0 1/3] mem_access: modifications to mem_event enable API Dushyant Behl
[not found] ` <CAGU+auvmQOWp8VH5bt+yh55iyJxLOV6Hd8ZfvAsdyuOOZ3fBNQ@mail.gmail.com>
2014-08-22 22:05 ` Aravindh Puthiyaparambil (aravindp)
2014-08-25 0:16 ` Dushyant Behl
2014-08-25 17:48 ` Aravindh Puthiyaparambil (aravindp)
2014-08-26 17:50 ` Ian Campbell [this message]
2014-08-13 20:51 ` [PATCH v0 2/3] mem_event: Added new helper API to teardown mem event setup and unmap ring_page Dushyant Behl
[not found] ` <CAGU+auudSP7mXfGzMzhDm4WkwS7icGy_rFCAWHhN85xe_pF=Og@mail.gmail.com>
2014-08-22 22:24 ` Aravindh Puthiyaparambil (aravindp)
2014-08-13 20:51 ` [PATCH v0 3/3] xenpaging: updated code to use safer mem_event API's for setup and teardown Dushyant Behl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1409075443.28009.15.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=andres.lagarcavilla@gmail.com \
--cc=aravindp@cisco.com \
--cc=dave.scott@eu.citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=myselfdushyantbehl@gmail.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).