From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v0 1/3] mem_access: modifications to mem_event enable API. Date: Tue, 26 Aug 2014 18:50:43 +0100 Message-ID: <1409075443.28009.15.camel@citrix.com> References: <1407963100-18796-1-git-send-email-myselfdushyantbehl@gmail.com> <1407963100-18796-2-git-send-email-myselfdushyantbehl@gmail.com> <97A500D504438F4ABC02EBA81613CC63318E06E6@xmb-aln-x02.cisco.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <97A500D504438F4ABC02EBA81613CC63318E06E6@xmb-aln-x02.cisco.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: "Aravindh Puthiyaparambil (aravindp)" Cc: David Scott , Stefano Stabellini , Ian Jackson , "xen-devel@lists.xen.org" , Andres Lagar Cavilla , Dushyant Behl List-Id: xen-devel@lists.xenproject.org On Fri, 2014-08-22 at 22:05 +0000, Aravindh Puthiyaparambil (aravindp) wrote: > >4. The API xc_mem_event_enable is now modified to return int rather than > >void *, > > this was done to synchronize this API's behaviour with other mem_event > >API's. > > FWIW, since I am the one that introduced this... I am fine with the > change. Though I did think that the norm was to return -1 on error and > set errno to the appropriate value. Sadly there isn't really a norm in libxc now, we use basically every possible way of returning errors. In so far as we are moving in any particular direction to try and rationalise this I think we are trying to get to set errno and return -1 (like a normal POSIXy library) Ian.