From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH 02/13] Config.mk: replace dependency to
 genpath with actual target
Date: Tue, 26 Aug 2014 21:00:53 +0100
Message-ID: <1409083253.28009.20.camel@citrix.com>
References: <1406538316-29087-1-git-send-email-olaf@aepfle.de>
	<1406538316-29087-3-git-send-email-olaf@aepfle.de>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1406538316-29087-3-git-send-email-olaf@aepfle.de>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Olaf Hering <olaf@aepfle.de>
Cc: Keir Fraser <keir@xen.org>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Tim Deegan <tim@xen.org>, Ian Jackson <ian.jackson@eu.citrix.com>, xen-devel@lists.xen.org, Jan Beulich <jbeulich@suse.com>, Samuel Thibault <samuel.thibault@ens-lyon.org>
List-Id: xen-devel@lists.xenproject.org

On Mon, 2014-07-28 at 11:05 +0200, Olaf Hering wrote:

Sorry for the delay in looking into this, I've been on vacation and
travel.

> genpath is a detail of buildmakevars2file. Replace the dependency to
> genpath with the actual buildmakevars2file target. This change by
> itself does not fix any bug. Upcoming changes will add dependencies to
> $(target), but no rule exist to create $(target).
> 
> No change in behaviour is expected by this patch.
> 
> Note: target.tmp ($(1).tmp) is not marked as .PHONY because
> move-if-changed in the target rule will remove target.tmp by renaming
> it to target. As a result make will always attempt to rebuild it.

Does the scheme you've got here end up differing from:

    $(1):
       rm -f $(1).tmp; \
        $(foreach var, $(BUILD_MAKE_VARS), \
                 echo "$(var)=\"$($(var))\"" >>$(1).tmp;) \
        $(call move-if-changed,$(1).tmp,$(1))

(i.e. avoiding the $(1).tmp rule)

Ian.