From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v2 03/18] libxl: functions to lock / unlock domain data in libxl user data store Date: Tue, 26 Aug 2014 22:21:34 +0100 Message-ID: <1409088094.28009.53.camel@citrix.com> References: <1406744639-28782-1-git-send-email-wei.liu2@citrix.com> <1406744639-28782-4-git-send-email-wei.liu2@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1406744639-28782-4-git-send-email-wei.liu2@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu Cc: ian.jackson@eu.citrix.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Wed, 2014-07-30 at 19:23 +0100, Wei Liu wrote: > The term "domain data" means libxl's knowledge of a domain, which > includes but not limit to domain configuration. A new "libxl-lock" entry "is not limited to" > Portability note: this lock utilises flock(2) so a proper implementation > of flock(2) is required. I suppose Linux provides this, do you know about BSD? (IOW, how much of a problem is this in reality) > + * "libxl-lock" lock file to protect domain data in libxl. It's per-domain "It's a per-domain..." or just "Per-domain...". > + default: > + /* All other errno: EBADF, EINVAL, ENOLCK, EWOULDBLOCK */ > + LOGE(ERROR, > + "unexpcted error while trying to lock %s, fd=%d, errno=%d", "unexpected" Other than those nits: Acked-by: Ian Campbell