Re: [v4][PATCH 5/9] hvm_info_table: introduce nr_reserved_device_memory_map

[Ian Campbell <ian.campbell@citrix.com>]

On Wed, 2014-08-27 at 09:54 +0800, Chen, Tiejun wrote:
> On 2014/8/27 4:38, Ian Campbell wrote:
> > On Fri, 2014-08-22 at 18:09 +0800, Tiejun Chen wrote:
> >> libxc can expose how many reserved device memory entries
> >> hvmloader should get.
> >
> > "get" in what sense?
> >
> >>   And '0' means that doesn't exist so
> >> we can skip this check.
> >
> > Which check?
> >
> > The code is trivial enough that I guess it is correct, and I don't
> > expect a full explanation here (since I assume that comes in some future
> > patch) but an accurate/meaningful quick indication would be useful here.
> >
> 
> Okay, I think I should describe this case explicitly as follows:
> 
>      hvm_info_table: introduce nr_reserved_device_memory_map
> 
>      libxc can expose how many reserved device memory entries to
>      notify hvmloader. 

"libxc exposes to hvmloader the number of reserved device memory entries
which are present" is what I think you are trying to say.

> Then hvmloader would check if those reserved

s/would/will/

>      memory overlap current memory range in e820.
> 
>      Note if nr_reserved_device_memory_map is '0', this means we have
>      any reserved device memory so we can skip that check.

s/any/no/ ?

Ian.