From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [v4][PATCH 5/9] hvm_info_table: introduce
 nr_reserved_device_memory_map
Date: Wed, 27 Aug 2014 03:21:55 +0100
Message-ID: <1409106115.28009.86.camel@citrix.com>
References: <1408702186-24432-1-git-send-email-tiejun.chen@intel.com>
	<1408702186-24432-6-git-send-email-tiejun.chen@intel.com>
	<1409085519.28009.39.camel@citrix.com> <53FD3A56.5020205@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <53FD3A56.5020205@intel.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: "Chen, Tiejun" <tiejun.chen@intel.com>
Cc: kevin.tian@intel.com, stefano.stabellini@eu.citrix.com, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org, JBeulich@suse.com, yang.z.zhang@intel.com
List-Id: xen-devel@lists.xenproject.org

On Wed, 2014-08-27 at 09:54 +0800, Chen, Tiejun wrote:
> On 2014/8/27 4:38, Ian Campbell wrote:
> > On Fri, 2014-08-22 at 18:09 +0800, Tiejun Chen wrote:
> >> libxc can expose how many reserved device memory entries
> >> hvmloader should get.
> >
> > "get" in what sense?
> >
> >>   And '0' means that doesn't exist so
> >> we can skip this check.
> >
> > Which check?
> >
> > The code is trivial enough that I guess it is correct, and I don't
> > expect a full explanation here (since I assume that comes in some future
> > patch) but an accurate/meaningful quick indication would be useful here.
> >
> 
> Okay, I think I should describe this case explicitly as follows:
> 
>      hvm_info_table: introduce nr_reserved_device_memory_map
> 
>      libxc can expose how many reserved device memory entries to
>      notify hvmloader. 

"libxc exposes to hvmloader the number of reserved device memory entries
which are present" is what I think you are trying to say.

> Then hvmloader would check if those reserved

s/would/will/

>      memory overlap current memory range in e820.
> 
>      Note if nr_reserved_device_memory_map is '0', this means we have
>      any reserved device memory so we can skip that check.

s/any/no/ ?

Ian.