From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tamas K Lengyel Subject: [PATCH RFC v2 05/12] xen/mem_access: Abstract architecture specific sanity check Date: Wed, 27 Aug 2014 16:06:33 +0200 Message-ID: <1409148400-14810-6-git-send-email-tklengyel@sec.in.tum.de> References: <1409148400-14810-1-git-send-email-tklengyel@sec.in.tum.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1409148400-14810-1-git-send-email-tklengyel@sec.in.tum.de> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: xen-devel@lists.xen.org Cc: ian.campbell@citrix.com, tim@xen.org, ian.jackson@eu.citrix.com, stefano.stabellini@citrix.com, andres@lagarcavilla.org, jbeulich@suse.com, dgdegra@tycho.nsa.gov, Tamas K Lengyel List-Id: xen-devel@lists.xenproject.org Signed-off-by: Tamas K Lengyel --- xen/common/mem_access.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/xen/common/mem_access.c b/xen/common/mem_access.c index 84acdf9..2bb3171 100644 --- a/xen/common/mem_access.c +++ b/xen/common/mem_access.c @@ -30,6 +30,12 @@ #include #ifdef CONFIG_X86 +static inline bool_t mem_access_sanity_check(struct domain *d) +{ + if ( !is_hvm_domain(d) ) + return 0; + return 1; +} int mem_access_memop(unsigned long cmd, XEN_GUEST_HANDLE_PARAM(xen_mem_access_op_t) arg) @@ -45,9 +51,11 @@ int mem_access_memop(unsigned long cmd, if ( rc ) return rc; - rc = -EINVAL; - if ( !is_hvm_domain(d) ) + if ( !mem_access_sanity_check(d) ) + { + rc = -EINVAL; goto out; + } rc = xsm_mem_event_op(XSM_DM_PRIV, d, XENMEM_access_op); if ( rc ) -- 2.1.0.rc1