xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Tamas K Lengyel <tklengyel@sec.in.tum.de>
To: xen-devel@lists.xen.org
Cc: ian.campbell@citrix.com, tim@xen.org, ian.jackson@eu.citrix.com,
	stefano.stabellini@citrix.com, andres@lagarcavilla.org,
	jbeulich@suse.com, dgdegra@tycho.nsa.gov,
	Tamas K Lengyel <tklengyel@sec.in.tum.de>
Subject: [PATCH RFC v2 08/12] xen/arm: Add mem_event domctl and mem_access memop.
Date: Wed, 27 Aug 2014 16:06:36 +0200	[thread overview]
Message-ID: <1409148400-14810-9-git-send-email-tklengyel@sec.in.tum.de> (raw)
In-Reply-To: <1409148400-14810-1-git-send-email-tklengyel@sec.in.tum.de>

Define the handling of XEN_DOMCTL_mem_event_op and the handling of
copy-back data. Also setup the memop handling of XENMEM_access_op
with the required masking of the operation with MEMOP_CMD_MASK.

Signed-off-by: Tamas K Lengyel <tklengyel@sec.in.tum.de>
---
 xen/arch/arm/domctl.c | 34 ++++++++++++++++++++++++++++++----
 xen/arch/arm/mm.c     | 20 ++++++++++++++++----
 2 files changed, 46 insertions(+), 8 deletions(-)

diff --git a/xen/arch/arm/domctl.c b/xen/arch/arm/domctl.c
index 45974e7..c6d3cb4 100644
--- a/xen/arch/arm/domctl.c
+++ b/xen/arch/arm/domctl.c
@@ -11,10 +11,17 @@
 #include <xen/sched.h>
 #include <xen/hypercall.h>
 #include <public/domctl.h>
+#include <asm/guest_access.h>
+#include <xen/mem_event.h>
+#include <public/mem_event.h>
 
 long arch_do_domctl(struct xen_domctl *domctl, struct domain *d,
                     XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl)
 {
+
+    long ret;
+    bool_t copyback = 0;
+
     switch ( domctl->cmd )
     {
     case XEN_DOMCTL_cacheflush:
@@ -23,17 +30,36 @@ long arch_do_domctl(struct xen_domctl *domctl, struct domain *d,
         unsigned long e = s + domctl->u.cacheflush.nr_pfns;
 
         if ( domctl->u.cacheflush.nr_pfns > (1U<<MAX_ORDER) )
-            return -EINVAL;
+        {
+            ret = -EINVAL;
+            break;
+        }
 
         if ( e < s )
-            return -EINVAL;
+        {
+            ret = -EINVAL;
+            break;
+        }
 
-        return p2m_cache_flush(d, s, e);
+        ret = p2m_cache_flush(d, s, e);
     }
+    break;
+
+    case XEN_DOMCTL_mem_event_op:
+        ret = mem_event_domctl(d, &domctl->u.mem_event_op,
+                               guest_handle_cast(u_domctl, void));
+        copyback = 1;
+    break;
 
     default:
-        return subarch_do_domctl(domctl, d, u_domctl);
+        ret = subarch_do_domctl(domctl, d, u_domctl);
+        break;
     }
+
+    if ( copyback && __copy_to_guest(u_domctl, domctl, 1) )
+        ret = -EFAULT;
+
+    return ret;
 }
 
 void arch_get_info_guest(struct vcpu *v, vcpu_guest_context_u c)
diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c
index 0a243b0..a42c167 100644
--- a/xen/arch/arm/mm.c
+++ b/xen/arch/arm/mm.c
@@ -35,6 +35,9 @@
 #include <asm/current.h>
 #include <asm/flushtlb.h>
 #include <public/memory.h>
+#include <xen/mem_event.h>
+#include <xen/mem_access.h>
+#include <xen/hypercall.h>
 #include <xen/sched.h>
 #include <xen/vmap.h>
 #include <xsm/xsm.h>
@@ -1111,18 +1114,27 @@ int xenmem_add_to_physmap_one(
 
 long arch_memory_op(int op, XEN_GUEST_HANDLE_PARAM(void) arg)
 {
-    switch ( op )
+
+    long rc;
+
+    switch ( op & MEMOP_CMD_MASK )
     {
     /* XXX: memsharing not working yet */
     case XENMEM_get_sharing_shared_pages:
     case XENMEM_get_sharing_freed_pages:
-        return 0;
+        rc = 0;
+        break;
+
+    case XENMEM_access_op:
+        rc = mem_access_memop(op, guest_handle_cast(arg, xen_mem_access_op_t));
+        break;
 
     default:
-        return -ENOSYS;
+        rc = -ENOSYS;
+        break;
     }
 
-    return 0;
+    return rc;
 }
 
 struct domain *page_get_owner_and_reference(struct page_info *page)
-- 
2.1.0.rc1

  parent reply	other threads:[~2014-08-27 14:06 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-27 14:06 [PATCH RFC v2 00/12] Mem_event and mem_access for ARM Tamas K Lengyel
2014-08-27 14:06 ` [PATCH RFC v2 01/12] xen: Relocate mem_access and mem_event into common Tamas K Lengyel
2014-08-27 14:17   ` Julien Grall
2014-08-27 14:57     ` Tamas K Lengyel
2014-08-28 10:22   ` Tim Deegan
2014-08-27 14:06 ` [PATCH RFC v2 02/12] xen/mem_event: Clean out superflous white-spaces Tamas K Lengyel
2014-08-28 10:22   ` Tim Deegan
2014-08-27 14:06 ` [PATCH RFC v2 03/12] xen/mem_event: Relax error condition on debug builds Tamas K Lengyel
2014-08-27 16:39   ` Julien Grall
2014-08-27 17:00     ` Tamas K Lengyel
2014-08-27 17:02   ` Andres Lagar Cavilla
2014-08-27 21:26     ` Tamas K Lengyel
2014-08-28  6:36     ` Jan Beulich
2014-08-29  4:20       ` Andres Lagar Cavilla
2014-08-27 14:06 ` [PATCH RFC v2 04/12] xen/mem_event: Abstract architecture specific sanity checks Tamas K Lengyel
2014-08-27 15:19   ` Jan Beulich
2014-08-27 17:17     ` Tamas K Lengyel
2014-08-27 21:54       ` Tamas K Lengyel
2014-08-28  6:38         ` Jan Beulich
2014-08-28  8:40           ` Tamas K Lengyel
2014-08-28  8:46             ` Jan Beulich
2014-08-28  8:52               ` Tamas K Lengyel
2014-08-27 14:06 ` [PATCH RFC v2 05/12] xen/mem_access: Abstract architecture specific sanity check Tamas K Lengyel
2014-08-27 14:06 ` [PATCH RFC v2 06/12] tools/libxc: Allocate magic page for mem access on ARM Tamas K Lengyel
2014-08-29 20:43   ` Julien Grall
2014-09-04  0:12   ` Stefano Stabellini
2014-08-27 14:06 ` [PATCH RFC v2 07/12] xen/arm: p2m type definitions and changes Tamas K Lengyel
2014-08-27 14:06 ` Tamas K Lengyel [this message]
2014-08-29 20:57   ` [PATCH RFC v2 08/12] xen/arm: Add mem_event domctl and mem_access memop Julien Grall
2014-08-30  8:19     ` Tamas K Lengyel
2014-08-27 14:06 ` [PATCH RFC v2 09/12] xen/arm: Data abort exception (R/W) mem_events Tamas K Lengyel
2014-08-27 17:01   ` Julien Grall
2014-08-27 17:22     ` Tamas K Lengyel
2014-08-29 21:41   ` Julien Grall
2014-08-30  8:16     ` Tamas K Lengyel
2014-08-27 14:06 ` [PATCH RFC v2 10/12] xen/arm: Instruction prefetch abort (X) mem_event handling Tamas K Lengyel
2014-08-27 14:06 ` [PATCH RFC v2 11/12] xen/arm: Enable the compilation of mem_access and mem_event on ARM Tamas K Lengyel
2014-08-27 15:24   ` Jan Beulich
2014-08-27 17:12     ` Tamas K Lengyel
2014-08-28  6:39       ` Jan Beulich
2014-08-28  8:42         ` Tamas K Lengyel
2014-08-28  8:54           ` Jan Beulich
2014-08-28  9:00             ` Tamas K Lengyel
2014-08-27 17:05   ` Daniel De Graaf
2014-08-27 17:13     ` Tamas K Lengyel
2014-08-27 14:06 ` [PATCH RFC v2 12/12] tools/tests: Enable xen-access " Tamas K Lengyel
2014-08-27 15:46 ` [PATCH RFC v2 00/12] Mem_event and mem_access for ARM Andrii Tseglytskyi
2014-08-27 17:05   ` Tamas K Lengyel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1409148400-14810-9-git-send-email-tklengyel@sec.in.tum.de \
    --to=tklengyel@sec.in.tum.de \
    --cc=andres@lagarcavilla.org \
    --cc=dgdegra@tycho.nsa.gov \
    --cc=ian.campbell@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=jbeulich@suse.com \
    --cc=stefano.stabellini@citrix.com \
    --cc=tim@xen.org \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).