From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v2 14/18] libxl: introduce libxl_get_memory_static_max Date: Thu, 28 Aug 2014 19:16:03 +0100 Message-ID: <1409249763.21481.22.camel@citrix.com> References: <1406744639-28782-1-git-send-email-wei.liu2@citrix.com> <1406744639-28782-15-git-send-email-wei.liu2@citrix.com> <1409105349.28009.78.camel@citrix.com> <20140828113133.GL13165@zion.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20140828113133.GL13165@zion.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu Cc: ian.jackson@eu.citrix.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Thu, 2014-08-28 at 12:31 +0100, Wei Liu wrote: > > > @@ -884,6 +891,7 @@ int libxl_domain_core_dump(libxl_ctx *ctx, uint32_t domid, > > > int libxl_domain_setmaxmem(libxl_ctx *ctx, uint32_t domid, uint32_t target_memkb); > > > int libxl_set_memory_target(libxl_ctx *ctx, uint32_t domid, int32_t target_memkb, int relative, int enforce); > > > int libxl_get_memory_target(libxl_ctx *ctx, uint32_t domid, uint32_t *out_target); > > > +int libxl_get_memory_static_max(libxl_ctx *ctx, uint32_t domid, uint32_t *out_static_max); > > > > Do you need this to be public, or did you just do it for consistency? > > > > I did it for consistency, in case it's useful to library users. If you > would rather not expose this I can make it internal. In general I'm wary of adding to the API "just because". Refactoring an internal function to be externally available when a requirement arises is pretty easy, whereas changing an already public function because the eventual requirement turned out not to be what we expected is harder. Ian.