From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH v2 15/18] libxl: introduce
 libxl_retrieve_domain_configuration
Date: Thu, 28 Aug 2014 19:17:14 +0100
Message-ID: <1409249834.21481.23.camel@citrix.com>
References: <1406744639-28782-1-git-send-email-wei.liu2@citrix.com>
	<1406744639-28782-16-git-send-email-wei.liu2@citrix.com>
	<1409105632.28009.80.camel@citrix.com>
	<20140828113920.GM13165@zion.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20140828113920.GM13165@zion.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wei Liu <wei.liu2@citrix.com>
Cc: ian.jackson@eu.citrix.com, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On Thu, 2014-08-28 at 12:39 +0100, Wei Liu wrote:
> On Wed, Aug 27, 2014 at 03:13:52AM +0100, Ian Campbell wrote:
> > On Wed, 2014-07-30 at 19:23 +0100, Wei Liu wrote:
> > > +    /* Domain name */
> > 
> > > +    /* Domain UUID */
> > 
> > Wasn't there a new libxl__update_domain_configuration which does a bunch
> > of this for you already?
> > 
> 
> It updates UUID in JSON config but not domain name. I would still prefer
> to use xenstore as primary reference for information like domain name
> and UUID etc.

Calling libxl__update_domain_configuration doesn't violate that though,
does it? IOW that function uses xenstore as the primary reference for
the UUID, so why not reuse it instead of open coding it a second time.

Ian.