From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xen.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
Jan Beulich <JBeulich@suse.com>
Subject: [PATCH] x86/current: Provide additional information to optimise get_cpu_info()
Date: Mon, 1 Sep 2014 11:58:50 +0100 [thread overview]
Message-ID: <1409569130-19066-1-git-send-email-andrew.cooper3@citrix.com> (raw)
Exactly as with c/s d55c5eefe "x86: use compiler visible "add" instead of
inline assembly "or" in get_cpu_info()", this is achieved by providing more
information to the compiler.
With this modification, gcc replaces the older:
mov imm, %reg
and %rsp, %reg
with:
mov %rsp, %reg
and imm, %reg
which is one byte shorter. It also considers all general purpose registers
for %reg rather than just the legacy ones (i.e. will now use %r12 etc), which
allows for better register scheduling in larger functions.
This causes a net drop of almost 4K of .text
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
CC: Jan Beulich <JBeulich@suse.com>
---
xen/include/asm-x86/current.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/xen/include/asm-x86/current.h b/xen/include/asm-x86/current.h
index 2081015..b95fd79 100644
--- a/xen/include/asm-x86/current.h
+++ b/xen/include/asm-x86/current.h
@@ -25,9 +25,9 @@ struct cpu_info {
static inline struct cpu_info *get_cpu_info(void)
{
- unsigned long tos;
- __asm__ ( "and %%rsp,%0" : "=r" (tos) : "0" (~(STACK_SIZE-1)) );
- return (struct cpu_info *)(tos + STACK_SIZE) - 1;
+ register unsigned long sp asm("rsp");
+
+ return (struct cpu_info *)((sp & ~(STACK_SIZE-1)) + STACK_SIZE) - 1;
}
#define get_current() (get_cpu_info()->current_vcpu)
--
1.7.10.4
next reply other threads:[~2014-09-01 10:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-01 10:58 Andrew Cooper [this message]
2014-09-01 11:24 ` [PATCH] x86/current: Provide additional information to optimise get_cpu_info() Jan Beulich
2014-09-01 12:18 ` Andrew Cooper
2014-09-01 12:32 ` Jan Beulich
2014-09-01 15:27 ` [PATCH v2] " Andrew Cooper
2014-09-13 16:10 ` Marcin Cieslak
2014-09-15 8:16 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1409569130-19066-1-git-send-email-andrew.cooper3@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=JBeulich@suse.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).