From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@eu.citrix.com>
Subject: Re: [PATCH v12 10/14] xsm/flask: avoid spurious error
 messages when mapping I/O-memory
Date: Wed, 3 Sep 2014 12:22:07 +0100
Message-ID: <1409743327.22712.11.camel@eu.citrix.com>
References: <1409416189-16564-1-git-send-email-avanzini.arianna@gmail.com>
	<1409416189-16564-11-git-send-email-avanzini.arianna@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1409416189-16564-11-git-send-email-avanzini.arianna@gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Arianna Avanzini <avanzini.arianna@gmail.com>
Cc: paolo.valente@unimore.it, keir@xen.org, stefano.stabellini@eu.citrix.com, Ian.Jackson@eu.citrix.com, dario.faggioli@citrix.com, tim@xen.org, xen-devel@lists.xen.org, julien.grall@citrix.com, etrudeau@broadcom.com, JBeulich@suse.com, andrew.cooper3@citrix.com, viktor.kleinik@globallogic.com, andrii.tseglytskyi@globallogic.com
List-Id: xen-devel@lists.xenproject.org

On Sat, 2014-08-30 at 18:29 +0200, Arianna Avanzini wrote:
> Currently, FLASK only handles the memory_mapping hypercall for the
> x86 architecture. In case the architecture is ARM, an error message
> will be printed regardless of how XSM has been configured. This
> commit lets the memory_mapping case be handled also for architectures
> other than x86.
> 
> Signed-off-by: Arianna Avanzini <avanzini.arianna@gmail.com>
> Reviewed-by: Julien Grall <julien.grall@citrix.com>
> Cc: Dario Faggioli <dario.faggioli@citrix.com>
> Cc: Paolo Valente <paolo.valente@unimore.it>
> Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>

Acked-by: Ian Campbell <Ian.Campbell@eu.citrix.com>

> Cc: Jan Beulich <JBeulich@suse.com>
> Cc: Keir Fraser <keir@xen.org>
> Cc: Tim Deegan <tim@xen.org>
> Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>
> Cc: Andrew Cooper <andrew.cooper3@citrix.com>
> Cc: Eric Trudeau <etrudeau@broadcom.com>
> Cc: Viktor Kleinik <viktor.kleinik@globallogic.com>
> Cc: Andrii Tseglytskyi <andrii.tseglytskyi@globallogic.com>
> ---
>  xen/xsm/flask/hooks.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/xen/xsm/flask/hooks.c b/xen/xsm/flask/hooks.c
> index f2f59ea..a0e4ae0 100644
> --- a/xen/xsm/flask/hooks.c
> +++ b/xen/xsm/flask/hooks.c
> @@ -570,6 +570,7 @@ static int flask_domctl(struct domain *d, int cmd)
>      case XEN_DOMCTL_scheduler_op:
>      case XEN_DOMCTL_irq_permission:
>      case XEN_DOMCTL_iomem_permission:
> +    case XEN_DOMCTL_memory_mapping:
>      case XEN_DOMCTL_set_target:
>  #ifdef CONFIG_X86
>      /* These have individual XSM hooks (arch/x86/domctl.c) */
> @@ -577,7 +578,6 @@ static int flask_domctl(struct domain *d, int cmd)
>      case XEN_DOMCTL_ioport_permission:
>      case XEN_DOMCTL_bind_pt_irq:
>      case XEN_DOMCTL_unbind_pt_irq:
> -    case XEN_DOMCTL_memory_mapping:
>      case XEN_DOMCTL_ioport_mapping:
>      case XEN_DOMCTL_mem_event_op:
>      /* These have individual XSM hooks (drivers/passthrough/iommu.c) */