From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v12 12/14] tools/libxl: explicitly grant access to needed I/O-memory ranges Date: Wed, 3 Sep 2014 12:26:22 +0100 Message-ID: <1409743582.22712.13.camel@eu.citrix.com> References: <1409416189-16564-1-git-send-email-avanzini.arianna@gmail.com> <1409416189-16564-13-git-send-email-avanzini.arianna@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1409416189-16564-13-git-send-email-avanzini.arianna@gmail.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Arianna Avanzini Cc: paolo.valente@unimore.it, keir@xen.org, stefano.stabellini@eu.citrix.com, Ian.Jackson@eu.citrix.com, dario.faggioli@citrix.com, tim@xen.org, xen-devel@lists.xen.org, julien.grall@citrix.com, etrudeau@broadcom.com, JBeulich@suse.com, andrew.cooper3@citrix.com, viktor.kleinik@globallogic.com, andrii.tseglytskyi@globallogic.com List-Id: xen-devel@lists.xenproject.org On Sat, 2014-08-30 at 18:29 +0200, Arianna Avanzini wrote: > + if (!d_config->b_info.u.hvm.gfx_passthru.val) You have to use libxl_defbool_val() to read a defbool, val is not a bool in the normal sense and can't be treated as such. Ian.