From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v2 07/18] libxl: separate device add/rm complete callbacks Date: Wed, 3 Sep 2014 12:53:55 +0100 Message-ID: <1409745235.20794.5.camel@citrix.com> References: <1406744639-28782-1-git-send-email-wei.liu2@citrix.com> <1406744639-28782-8-git-send-email-wei.liu2@citrix.com> <1409103715.28009.64.camel@citrix.com> <20140828103415.GF13165@zion.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20140828103415.GF13165@zion.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu Cc: ian.jackson@eu.citrix.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Thu, 2014-08-28 at 11:34 +0100, Wei Liu wrote: > > > + libxl__ao_complete(egc, ao, aodev->rc); \ > > > + } > > > + > > > +/* > > > + * device_vtpm_rm_aocomplete > > > + * device_nic_rm_aocomplete > > > + * device_disk_rm_aocomplete > > > + * device_vfb_rm_aocomplete > > > + * device_vkb_rm_aocomplete > > > + */ > > > +DEFINE_DEVICE_RM_AOCOMPLETE(vtpm); > > > +DEFINE_DEVICE_RM_AOCOMPLETE(nic); > > > +DEFINE_DEVICE_RM_AOCOMPLETE(disk); > > > +DEFINE_DEVICE_RM_AOCOMPLETE(vfb); > > > +DEFINE_DEVICE_RM_AOCOMPLETE(vkb); > > > > I was going to suggest merging this with DEFINE_DEVICE_REMOVE but that > > is used twice for each device so that won't work. But perhaps consider > > adding these in the same blocks as the usage of DEFINE_DEVICE_REMOVE? > > > > They're already placed right before DEFINE_DEVICE_RM macro. You > requested this in your last review so I've done it already. ;-) Heh, what I meant there was to end up with: /* disk */ DEFINE_DEVICE_RM_AOCOMPLETE(disk); DEFINE_DEVICE_REMOVE(disk, remove, 0) DEFINE_DEVICE_REMOVE(disk, destroy, 1) /* nic */