From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH] numa.c: convert to xen coding style Date: Thu, 4 Sep 2014 12:43:29 +0200 Message-ID: <1409827409.2673.161.camel@Solace.lan> References: <1409803484-15839-1-git-send-email-ufimtseva@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6199724745284990893==" Return-path: In-Reply-To: <1409803484-15839-1-git-send-email-ufimtseva@gmail.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Elena Ufimtseva Cc: keir@xen.org, Ian.Campbell@citrix.com, george.dunlap@eu.citrix.com, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org, JBeulich@suse.com List-Id: xen-devel@lists.xenproject.org --===============6199724745284990893== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-Vsrcix8FovOjXzV7zgY8" --=-Vsrcix8FovOjXzV7zgY8 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On gio, 2014-09-04 at 00:04 -0400, Elena Ufimtseva wrote: > Convert to Xen coding style from mixed one. >=20 Ah... Much better, thanks Elena for doing this! :-) I only have one nit. > --- a/xen/arch/x86/numa.c > +++ b/xen/arch/x86/numa.c > void __init numa_init_array(void) > { > - int rr, i; > - /* There are unfortunately some poorly designed mainboards around > - that only connect memory to a single CPU. This breaks the 1:1 cpu->n= ode > - mapping. To avoid this fill in the mapping for all possible > - CPUs, as the number of CPUs is not known yet.=20 > - We round robin the existing nodes. */ > - rr =3D first_node(node_online_map); > - for (i =3D 0; i < nr_cpu_ids; i++) { > - if (cpu_to_node[i] !=3D NUMA_NO_NODE) > - continue; > - numa_set_node(i, rr); > - rr =3D next_node(rr, node_online_map); > - if (rr =3D=3D MAX_NUMNODES) > - rr =3D first_node(node_online_map); > - } > - > + int rr, i; > + /* There are unfortunately some poorly designed mainboards around > + that only connect memory to a single CPU. This breaks the 1:1 cpu= ->node > + mapping. To avoid this fill in the mapping for all possible > + CPUs, as the number of CPUs is not known yet. > + We round robin the existing nodes. */ > We are not super consistent when it comes to code comments, but I think this should have become something like this: /* * Example, multi-line comment block. * * Note beginning and end markers on separate lines and leading '*'. */ With this fixed, Reviewed-by: Dario Faggioli Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-Vsrcix8FovOjXzV7zgY8 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEABECAAYFAlQIQlEACgkQk4XaBE3IOsRSNACfY9MHV4rV/wkwbkDi4X0A4gAp 1/YAoKhYaSjSq3Rdh633V4cKdWP11ZAZ =UVB4 -----END PGP SIGNATURE----- --=-Vsrcix8FovOjXzV7zgY8-- --===============6199724745284990893== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============6199724745284990893==--