From: vijay.kilari@gmail.com
To: Ian.Campbell@citrix.com, julien.grall@linaro.org,
stefano.stabellini@eu.citrix.com, stefano.stabellini@citrix.com,
tim@xen.org, xen-devel@lists.xen.org
Cc: Prasun.Kapoor@caviumnetworks.com,
Vijaya Kumar K <Vijaya.Kumar@caviumnetworks.com>,
jbeulich@suse.com, manish.jaggi@caviumnetworks.com,
vijay.kilari@gmail.com
Subject: [PATCH v9 7/7] xen/arm: check for GICv3 platform support
Date: Thu, 4 Sep 2014 18:45:27 +0530 [thread overview]
Message-ID: <1409836527-16526-8-git-send-email-vijay.kilari@gmail.com> (raw)
In-Reply-To: <1409836527-16526-1-git-send-email-vijay.kilari@gmail.com>
From: Vijaya Kumar K <Vijaya.Kumar@caviumnetworks.com>
ID_AA64PFR0_EL1 register provides information about GIC support.
Check for this register in GICv3 driver.
Also print GICv3 support information in boot log
Signed-off-by: Vijaya Kumar K <Vijaya.Kumar@caviumnetworks.com>
---
v9: - Correct error message
v8: - Rearranged prf64 structure member variables
v7: - return -ENODEV on lack GICv3 platform support instead of
panic
---
xen/arch/arm/gic-v3.c | 7 +++++++
xen/arch/arm/setup.c | 5 +++--
xen/include/asm-arm/cpufeature.h | 1 +
xen/include/asm-arm/processor.h | 4 ++--
4 files changed, 13 insertions(+), 4 deletions(-)
diff --git a/xen/arch/arm/gic-v3.c b/xen/arch/arm/gic-v3.c
index ca450f9..5465b88 100644
--- a/xen/arch/arm/gic-v3.c
+++ b/xen/arch/arm/gic-v3.c
@@ -39,6 +39,7 @@
#include <asm/device.h>
#include <asm/gic.h>
#include <asm/gic_v3_defs.h>
+#include <asm/cpufeature.h>
struct rdist_region {
paddr_t base;
@@ -1158,6 +1159,12 @@ static int __init gicv3_init(struct dt_device_node *node, const void *data)
int res, i;
uint32_t reg;
+ if ( !cpu_has_gicv3 )
+ {
+ dprintk(XENLOG_ERR, "GICv3: driver requests system register support\n");
+ return -ENODEV;
+ }
+
dt_device_set_used_by(node, DOMID_XEN);
res = dt_device_get_address(node, 0, &gicv3.dbase, &gicv3.dbase_size);
diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c
index ddaef7e..2e80b5a 100644
--- a/xen/arch/arm/setup.c
+++ b/xen/arch/arm/setup.c
@@ -103,9 +103,10 @@ static void __init processor_id(void)
cpu_has_el2_32 ? "64+32" : cpu_has_el2_64 ? "64" : "No",
cpu_has_el1_32 ? "64+32" : cpu_has_el1_64 ? "64" : "No",
cpu_has_el0_32 ? "64+32" : cpu_has_el0_64 ? "64" : "No");
- printk(" Extensions:%s%s\n",
+ printk(" Extensions:%s%s%s\n",
cpu_has_fp ? " FloatingPoint" : "",
- cpu_has_simd ? " AdvancedSIMD" : "");
+ cpu_has_simd ? " AdvancedSIMD" : "",
+ cpu_has_gicv3 ? " GICv3-SysReg" : "");
printk(" Debug Features: %016"PRIx64" %016"PRIx64"\n",
boot_cpu_data.dbg64.bits[0], boot_cpu_data.dbg64.bits[1]);
diff --git a/xen/include/asm-arm/cpufeature.h b/xen/include/asm-arm/cpufeature.h
index 1d2c9c7..aec9173 100644
--- a/xen/include/asm-arm/cpufeature.h
+++ b/xen/include/asm-arm/cpufeature.h
@@ -15,6 +15,7 @@
#define cpu_has_el3_64 (boot_cpu_feature64(el3) >= 1)
#define cpu_has_fp (boot_cpu_feature64(fp) == 0)
#define cpu_has_simd (boot_cpu_feature64(simd) == 0)
+#define cpu_has_gicv3 (boot_cpu_feature64(gic) == 1)
#endif
#define cpu_feature32(c, feat) ((c)->pfr32.feat)
diff --git a/xen/include/asm-arm/processor.h b/xen/include/asm-arm/processor.h
index d83f593..1993af7 100644
--- a/xen/include/asm-arm/processor.h
+++ b/xen/include/asm-arm/processor.h
@@ -250,8 +250,8 @@ struct cpuinfo_arm {
unsigned long el3:4;
unsigned long fp:4; /* Floating Point */
unsigned long simd:4; /* Advanced SIMD */
- unsigned long __res0:8;
-
+ unsigned long gic:4; /* GIC support */
+ unsigned long __res0:4;
unsigned long __res1;
};
} pfr64;
--
1.7.9.5
next prev parent reply other threads:[~2014-09-04 13:15 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-04 13:15 [PATCH v9 0/7] xen/arm: Add GICv3 support vijay.kilari
2014-09-04 13:15 ` [PATCH v9 1/7] xen/arm: move itargets initialization to vgic-v2 vijay.kilari
2014-09-05 0:00 ` Stefano Stabellini
2014-09-09 10:37 ` Ian Campbell
2014-09-09 10:55 ` Vijay Kilari
2014-09-09 21:32 ` Stefano Stabellini
2014-09-08 20:30 ` Julien Grall
2014-09-09 4:43 ` Vijay Kilari
2014-09-04 13:15 ` [PATCH v9 2/7] xen/arm: fallback to vcpu 0 if get_target_vcpu handler not exists vijay.kilari
2014-09-05 0:02 ` Stefano Stabellini
2014-09-04 13:15 ` [PATCH v9 3/7] xen/arm: Add support for GIC v3 vijay.kilari
2014-09-05 0:27 ` Stefano Stabellini
2014-09-08 9:42 ` Ian Campbell
2014-09-09 4:34 ` Vijay Kilari
2014-09-09 18:18 ` Stefano Stabellini
2014-09-04 13:15 ` [PATCH v9 4/7] xen/arm: Add virtual GICv3 support vijay.kilari
2014-09-05 0:49 ` Stefano Stabellini
2014-09-08 20:35 ` Julien Grall
2014-09-08 22:05 ` Stefano Stabellini
2014-09-09 10:36 ` Ian Campbell
2014-09-09 18:04 ` Stefano Stabellini
2014-09-04 13:15 ` [PATCH v9 5/7] xen/arm: Update Dom0 GIC dt node with GICv3 information vijay.kilari
2014-09-04 13:15 ` [PATCH v9 6/7] xen/arm: add SGI handling for GICv3 vijay.kilari
2014-09-04 13:15 ` vijay.kilari [this message]
2014-09-08 9:45 ` [PATCH v9 7/7] xen/arm: check for GICv3 platform support Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1409836527-16526-8-git-send-email-vijay.kilari@gmail.com \
--to=vijay.kilari@gmail.com \
--cc=Ian.Campbell@citrix.com \
--cc=Prasun.Kapoor@caviumnetworks.com \
--cc=Vijaya.Kumar@caviumnetworks.com \
--cc=jbeulich@suse.com \
--cc=julien.grall@linaro.org \
--cc=manish.jaggi@caviumnetworks.com \
--cc=stefano.stabellini@citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).