xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Tamas K Lengyel <tklengyel@sec.in.tum.de>
To: xen-devel@lists.xen.org
Cc: ian.campbell@citrix.com, tim@xen.org, julien.grall@linaro.org,
	ian.jackson@eu.citrix.com, stefano.stabellini@citrix.com,
	andres@lagarcavilla.org, jbeulich@suse.com,
	dgdegra@tycho.nsa.gov, Tamas K Lengyel <tklengyel@sec.in.tum.de>
Subject: [PATCH v4 13/16] xen/arm: Shatter large pages when using mem_acces
Date: Fri,  5 Sep 2014 10:58:41 +0200	[thread overview]
Message-ID: <1409907524-12509-14-git-send-email-tklengyel@sec.in.tum.de> (raw)
In-Reply-To: <1409907524-12509-1-git-send-email-tklengyel@sec.in.tum.de>

When using mem_acccess+mem_event, the coarsest granularity is required
in the pagetables, therefore we shatter each large page (1GB/2MB) as we
apply the permission changes.

Signed-off-by: Tamas K Lengyel <tklengyel@sec.in.tum.de>
---
 xen/arch/arm/p2m.c | 23 ++++++++++++++++++++---
 1 file changed, 20 insertions(+), 3 deletions(-)

diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c
index c723f9a..35ca6c1 100644
--- a/xen/arch/arm/p2m.c
+++ b/xen/arch/arm/p2m.c
@@ -1178,7 +1178,16 @@ static int p2m_set_entry(struct domain *d, paddr_t paddr, p2m_access_t p2ma)
         goto out;
 
     if ( !p2m_table(*pte) )
-        goto done;
+    {
+        /* This is a mapping of a 1GB page, shatter it */
+        rc = p2m_create_table(d, pte, FIRST_SHIFT - PAGE_SHIFT, 1);
+        if ( rc < 0 )
+            goto out;
+
+        p2m->stats.shattered[1]++;
+        p2m->stats.mappings[1]--;
+        p2m->stats.mappings[2] += LPAE_ENTRIES;
+    }
 
     second = map_domain_page(pte->p2m.base);
     if ( !second )
@@ -1189,7 +1198,16 @@ static int p2m_set_entry(struct domain *d, paddr_t paddr, p2m_access_t p2ma)
         goto out;
 
     if ( !p2m_table(*pte) )
-        goto done;
+    {
+        /* This is a mapping of 2MB page, shatter it */
+        rc = p2m_create_table(d, pte, SECOND_SHIFT - PAGE_SHIFT, 1);
+        if ( rc < 0 )
+            goto out;
+
+        p2m->stats.shattered[2]++;
+        p2m->stats.mappings[2]--;
+        p2m->stats.mappings[3] += LPAE_ENTRIES;
+    }
 
     third = map_domain_page(pte->p2m.base);
     if ( !third )
@@ -1203,7 +1221,6 @@ static int p2m_set_entry(struct domain *d, paddr_t paddr, p2m_access_t p2ma)
     if ( !p2m_table(*pte) )
         pte->bits = 0;
 
-done:
     if ( p2m_valid(*pte) )
     {
         ASSERT(pte->p2m.type != p2m_invalid);
-- 
2.1.0

  parent reply	other threads:[~2014-09-05  8:58 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-05  8:58 [PATCH v4 00/16] Mem_event and mem_access for ARM Tamas K Lengyel
2014-09-05  8:58 ` [PATCH v4 01/16] xen: Relocate mem_access and mem_event into common Tamas K Lengyel
2014-09-05  9:14   ` Jan Beulich
2014-09-05  9:45     ` Tamas K Lengyel
2014-09-05 10:07       ` Jan Beulich
2014-09-05 10:36         ` Tamas K Lengyel
2014-09-05 10:48           ` Jan Beulich
2014-09-05 10:52             ` Tamas K Lengyel
2014-09-05 11:26               ` Jan Beulich
2014-09-05 11:30                 ` Tamas K Lengyel
2014-09-05 11:46                   ` Jan Beulich
2014-09-05  8:58 ` [PATCH v4 02/16] xen: Relocate p2m_mem_access_resume to mem_access common Tamas K Lengyel
2014-09-05  9:16   ` Jan Beulich
2014-09-05  9:25     ` Tamas K Lengyel
2014-09-05  9:43       ` Jan Beulich
2014-09-05  9:48         ` Tamas K Lengyel
2014-09-05  8:58 ` [PATCH v4 03/16] xen: Relocate struct npfec definition into common Tamas K Lengyel
2014-09-05  8:58 ` [PATCH v4 04/16] xen: Relocate mem_event_op domctl and access_op memop " Tamas K Lengyel
2014-09-05  9:23   ` Jan Beulich
2014-09-05  9:29     ` Tamas K Lengyel
2014-09-05  8:58 ` [PATCH v4 05/16] xen/mem_event: Clean out superfluous white-spaces Tamas K Lengyel
2014-09-05  8:58 ` [PATCH v4 06/16] xen/mem_event: Relax error condition on debug builds Tamas K Lengyel
2014-09-05  9:25   ` Jan Beulich
2014-09-05  9:26     ` Tamas K Lengyel
2014-09-05  8:58 ` [PATCH v4 07/16] xen/mem_event: Abstract architecture specific sanity checks Tamas K Lengyel
2014-09-05  9:28   ` Jan Beulich
2014-09-05  9:35     ` Tamas K Lengyel
2014-09-05  9:44       ` Jan Beulich
2014-09-05  9:47         ` Tamas K Lengyel
2014-09-05  8:58 ` [PATCH v4 08/16] xen/mem_access: Abstract architecture specific sanity check Tamas K Lengyel
2014-09-05  9:29   ` Jan Beulich
2014-09-05  9:51     ` Tamas K Lengyel
2014-09-05  8:58 ` [PATCH v4 09/16] xen/arm: p2m type definitions and changes Tamas K Lengyel
2014-09-09  0:06   ` Julien Grall
2014-09-05  8:58 ` [PATCH v4 10/16] xen/arm: Add set access required domctl Tamas K Lengyel
2014-09-09  0:07   ` Julien Grall
2014-09-12 15:54     ` Tamas K Lengyel
2014-09-05  8:58 ` [PATCH v4 11/16] xen/arm: Data abort exception (R/W) mem_events Tamas K Lengyel
2014-09-09  0:25   ` Julien Grall
2014-09-05  8:58 ` [PATCH v4 12/16] xen/arm: Instruction prefetch abort (X) mem_event handling Tamas K Lengyel
2014-09-05  8:58 ` Tamas K Lengyel [this message]
2014-09-05  8:58 ` [PATCH v4 14/16] xen/arm: Enable the compilation of mem_access and mem_event on ARM Tamas K Lengyel
2014-09-05  8:58 ` [PATCH v4 15/16] tools/libxc: Allocate magic page for mem access " Tamas K Lengyel
2014-09-05  8:58 ` [PATCH v4 16/16] tools/tests: Enable xen-access " Tamas K Lengyel
2014-09-09  0:29   ` Julien Grall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1409907524-12509-14-git-send-email-tklengyel@sec.in.tum.de \
    --to=tklengyel@sec.in.tum.de \
    --cc=andres@lagarcavilla.org \
    --cc=dgdegra@tycho.nsa.gov \
    --cc=ian.campbell@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=jbeulich@suse.com \
    --cc=julien.grall@linaro.org \
    --cc=stefano.stabellini@citrix.com \
    --cc=tim@xen.org \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).