xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Zhuo Song <alfred.z.song@gmail.com>
To: xen-devel@lists.xen.org
Cc: ian.campbell@citrix.com, stefano.stabellini@eu.citrix.com,
	jinsong.liu@alibaba-inc.com, ian.jackson@eu.citrix.com,
	Zhuo Song <alfred.z.song@gmail.com>,
	Zhuo Song <songzhuo.sz@alibaba-inc.com>,
	boyu.mt@alibaba-inc.com
Subject: [PATCH] xc_cpuid_x86.c: No need to mask NX twice
Date: Fri,  5 Sep 2014 18:11:33 +0800	[thread overview]
Message-ID: <1409911893-18037-1-git-send-email-alfred.z.song@gmail.com> (raw)

Since amd_xc_cpuid_policy or intel_xc_cpuid_policy will do it later as
well, we may drop an extra action.

Signed-off-by: Zhuo Song <songzhuo.sz@alibaba-inc.com>
---
 tools/libxc/xc_cpuid_x86.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tools/libxc/xc_cpuid_x86.c b/tools/libxc/xc_cpuid_x86.c
index 6b81641..61af3e6 100644
--- a/tools/libxc/xc_cpuid_x86.c
+++ b/tools/libxc/xc_cpuid_x86.c
@@ -392,7 +392,6 @@ static void xc_cpuid_hvm_policy(
 
     case 0x80000001:
         if ( !is_pae ) {
-            clear_bit(X86_FEATURE_NX, regs[3]);
             clear_bit(X86_FEATURE_PSE36, regs[3]);
         }
         break;
-- 
1.8.5.2 (Apple Git-48)

             reply	other threads:[~2014-09-05 10:11 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-05 10:11 Zhuo Song [this message]
2014-09-05 10:32 ` [PATCH] xc_cpuid_x86.c: No need to mask NX twice Jan Beulich
2014-09-05 13:54   ` z
2014-09-05 14:10     ` Jan Beulich
2014-09-05 15:45       ` z
2014-09-05 16:09         ` Jan Beulich
2014-09-05 16:35           ` z
2014-09-08  6:59             ` Jan Beulich
2014-09-08  8:48               ` z
2014-09-08  9:09                 ` Jan Beulich
2014-09-08  9:56                   ` z
2014-09-08 10:54                     ` Jan Beulich
2014-09-08 12:07                       ` z
2014-09-08 14:43                 ` z
2014-09-08 15:07                   ` Jan Beulich
2014-09-09  4:48                     ` z

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1409911893-18037-1-git-send-email-alfred.z.song@gmail.com \
    --to=alfred.z.song@gmail.com \
    --cc=boyu.mt@alibaba-inc.com \
    --cc=ian.campbell@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=jinsong.liu@alibaba-inc.com \
    --cc=songzhuo.sz@alibaba-inc.com \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).