From: Tiejun Chen <tiejun.chen@intel.com>
To: JBeulich@suse.com, ian.campbell@citrix.com,
ian.jackson@eu.citrix.com, stefano.stabellini@eu.citrix.com,
kevin.tian@intel.com, yang.z.zhang@intel.com
Cc: xen-devel@lists.xen.org
Subject: [v6][PATCH 6/7] hvmloader: check to reserved device memory maps in e820
Date: Wed, 10 Sep 2014 13:49:49 +0800 [thread overview]
Message-ID: <1410328190-6372-7-git-send-email-tiejun.chen@intel.com> (raw)
In-Reply-To: <1410328190-6372-1-git-send-email-tiejun.chen@intel.com>
We need to check to reserve all reserved device memory maps in e820
to avoid any potential guest memory conflict.
Signed-off-by: Tiejun Chen <tiejun.chen@intel.com>
diff --git a/tools/firmware/hvmloader/e820.c b/tools/firmware/hvmloader/e820.c
index 2e05e93..b4842d9 100644
--- a/tools/firmware/hvmloader/e820.c
+++ b/tools/firmware/hvmloader/e820.c
@@ -68,12 +68,89 @@ void dump_e820_table(struct e820entry *e820, unsigned int nr)
}
}
+static unsigned int construct_rdm_e820_maps(unsigned int nr,
+ uint32_t nr_map,
+ struct xen_mem_reserved_device_memory *map,
+ struct e820entry *e820)
+{
+ unsigned int i = 0, j = 0, m = 0, sum_nr = nr + nr_map;
+ uint64_t start, end, rdm_start, rdm_end;
+ unsigned int insert = 0, do_insert = 0;
+
+ do_real_construct:
+ for ( i = 0; i < nr_map; i++ )
+ {
+ rdm_start = map[i].start_pfn << PAGE_SHIFT;
+ rdm_end = rdm_start + map[i].nr_pages * PAGE_SIZE;
+
+ for ( j = 0; j < nr - 1; j++ )
+ {
+ end = e820[j].addr + e820[j].size;
+ start = e820[j+1].addr;
+
+ /* Between those existing e820 entries. */
+ if ( (rdm_start > end) && (rdm_end < start) )
+ {
+ if ( do_insert )
+ {
+ /* Move to free this entry. */
+ for ( m = sum_nr - 1; m > j; m-- )
+ {
+ e820[m].addr = e820[m-1].addr;
+ e820[m].size = e820[m-1].size;
+ e820[m].type = e820[m-1].type;
+ }
+
+ /* Then fill RMRR into that entry. */
+ e820[j+1].addr = rdm_start;
+ e820[j+1].size = rdm_end - rdm_start;
+ e820[j+1].type = E820_RESERVED;
+ nr++;
+ }
+ insert++;
+ }
+ /* Already at the end. */
+ else if ( (rdm_start > end) && !start )
+ {
+ if ( do_insert )
+ {
+ e820[nr].addr = rdm_start;
+ e820[nr].size = rdm_end - rdm_start;
+ e820[nr].type = E820_RESERVED;
+ nr++;
+ }
+ insert++;
+ }
+ }
+ }
+
+ /* Just return if done. */
+ if ( do_insert )
+ return nr;
+
+ /* Fine to construct RDM mappings into e820. */
+ if ( insert == nr_map )
+ {
+ do_insert = 1;
+ goto do_real_construct;
+ }
+ /* Overlap. */
+ else
+ {
+ printf("RDM overlap with those existing e820 entries!\n");
+ printf("So we don't construct RDM mapping in e820!\n");
+ }
+
+ return nr;
+}
/* Create an E820 table based on memory parameters provided in hvm_info. */
int build_e820_table(struct e820entry *e820,
unsigned int lowmem_reserved_base,
unsigned int bios_image_base)
{
unsigned int nr = 0;
+ struct xen_mem_reserved_device_memory *map = NULL;
+ int rc;
if ( !lowmem_reserved_base )
lowmem_reserved_base = 0xA0000;
@@ -169,6 +246,29 @@ int build_e820_table(struct e820entry *e820,
nr++;
}
+ /* We'd better reserve RDM maps for each VM to avoid potential
+ * memory conflict.
+ */
+ if ( hvm_info->nr_reserved_device_memory_map )
+ {
+ if ( !map )
+ map = mem_alloc(hvm_info->nr_reserved_device_memory_map *
+ sizeof(struct xen_mem_reserved_device_memory), 0);
+ if ( map )
+ {
+ rc = get_reserved_device_memory_map(map,
+ hvm_info->nr_reserved_device_memory_map);
+ if ( !rc )
+ {
+ nr = construct_rdm_e820_maps(nr,
+ hvm_info->nr_reserved_device_memory_map,
+ map, e820);
+ }
+ }
+ else
+ printf("No space to get device reserved memory maps!\n");
+ }
+
return nr;
}
--
1.9.1
next prev parent reply other threads:[~2014-09-10 5:49 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-10 5:49 [v6][PATCH 0/7] xen: reserve RMRR to avoid conflicting MMIO/RAM Tiejun Chen
2014-09-10 5:49 ` [v6][PATCH 1/7] introduce XENMEM_reserved_device_memory_map Tiejun Chen
2014-09-10 21:34 ` Tian, Kevin
2014-09-10 5:49 ` [v6][PATCH 2/7] tools/libxc: introduce hypercall for xc_reserved_device_memory_map Tiejun Chen
2014-09-11 15:21 ` Jan Beulich
2014-09-11 15:23 ` Ian Campbell
2014-09-11 15:55 ` Andrew Cooper
2014-09-12 2:43 ` Chen, Tiejun
2014-09-12 6:20 ` Jan Beulich
2014-09-10 5:49 ` [v6][PATCH 3/7] tools/libxc: check if mmio BAR is out of reserved device memory maps Tiejun Chen
2014-09-10 21:37 ` Tian, Kevin
2014-09-11 1:14 ` Chen, Tiejun
2014-09-11 22:55 ` Tian, Kevin
2014-09-11 15:38 ` Jan Beulich
2014-09-12 2:56 ` Chen, Tiejun
2014-09-12 6:19 ` Jan Beulich
2014-09-10 5:49 ` [v6][PATCH 4/7] libxc/hvm_info_table: introduce a new field nr_reserved_device_memory_map Tiejun Chen
2014-09-10 21:39 ` Tian, Kevin
2014-09-11 1:16 ` Chen, Tiejun
2014-09-10 5:49 ` [v6][PATCH 5/7] hvmloader: introduce hypercall for xc_reserved_device_memory_map Tiejun Chen
2014-09-10 21:41 ` Tian, Kevin
2014-09-11 1:32 ` Chen, Tiejun
2014-09-11 7:52 ` Jan Beulich
2014-09-11 15:45 ` Jan Beulich
2014-09-12 4:52 ` Chen, Tiejun
2014-09-10 5:49 ` Tiejun Chen [this message]
2014-09-11 15:57 ` [v6][PATCH 6/7] hvmloader: check to reserved device memory maps in e820 Jan Beulich
2014-09-12 6:08 ` Jan Beulich
2014-09-12 6:28 ` Chen, Tiejun
2014-09-12 6:44 ` Jan Beulich
2014-09-10 5:49 ` [v6][PATCH 7/7] xen/vtd: make USB RMRR mapping safe Tiejun Chen
2014-09-18 9:11 ` Jan Beulich
2014-09-10 21:44 ` [v6][PATCH 0/7] xen: reserve RMRR to avoid conflicting MMIO/RAM Tian, Kevin
2014-09-11 1:38 ` Chen, Tiejun
2014-09-11 7:48 ` Jan Beulich
2014-09-11 9:39 ` Chen, Tiejun
2014-09-11 10:01 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1410328190-6372-7-git-send-email-tiejun.chen@intel.com \
--to=tiejun.chen@intel.com \
--cc=JBeulich@suse.com \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=kevin.tian@intel.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
--cc=yang.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).