xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Tiejun Chen <tiejun.chen@intel.com>
To: JBeulich@suse.com, ian.campbell@citrix.com,
	ian.jackson@eu.citrix.com, stefano.stabellini@eu.citrix.com,
	kevin.tian@intel.com, yang.z.zhang@intel.com
Cc: xen-devel@lists.xen.org
Subject: [v6][PATCH 7/7] xen/vtd: make USB RMRR mapping safe
Date: Wed, 10 Sep 2014 13:49:50 +0800	[thread overview]
Message-ID: <1410328190-6372-8-git-send-email-tiejun.chen@intel.com> (raw)
In-Reply-To: <1410328190-6372-1-git-send-email-tiejun.chen@intel.com>

We already reserve all RMRR mappings so USB should be safe with
RMRR.

Signed-off-by: Tiejun Chen <tiejun.chen@intel.com>

diff --git a/xen/drivers/passthrough/vtd/iommu.c b/xen/drivers/passthrough/vtd/iommu.c
index d513dba..ea5d343 100644
--- a/xen/drivers/passthrough/vtd/iommu.c
+++ b/xen/drivers/passthrough/vtd/iommu.c
@@ -2273,16 +2273,8 @@ static int intel_iommu_assign_device(
     if ( ret )
         goto done;
 
-    /* FIXME: Because USB RMRR conflicts with guest bios region,
-     * ignore USB RMRR temporarily.
-     */
     seg = pdev->seg;
     bus = pdev->bus;
-    if ( is_usb_device(seg, bus, pdev->devfn) )
-    {
-        ret = 0;
-        goto done;
-    }
 
     /* Setup rmrr identity mapping */
     for_each_rmrr_device( rmrr, bdf, i )
-- 
1.9.1

  parent reply	other threads:[~2014-09-10  5:49 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-10  5:49 [v6][PATCH 0/7] xen: reserve RMRR to avoid conflicting MMIO/RAM Tiejun Chen
2014-09-10  5:49 ` [v6][PATCH 1/7] introduce XENMEM_reserved_device_memory_map Tiejun Chen
2014-09-10 21:34   ` Tian, Kevin
2014-09-10  5:49 ` [v6][PATCH 2/7] tools/libxc: introduce hypercall for xc_reserved_device_memory_map Tiejun Chen
2014-09-11 15:21   ` Jan Beulich
2014-09-11 15:23     ` Ian Campbell
2014-09-11 15:55     ` Andrew Cooper
2014-09-12  2:43     ` Chen, Tiejun
2014-09-12  6:20       ` Jan Beulich
2014-09-10  5:49 ` [v6][PATCH 3/7] tools/libxc: check if mmio BAR is out of reserved device memory maps Tiejun Chen
2014-09-10 21:37   ` Tian, Kevin
2014-09-11  1:14     ` Chen, Tiejun
2014-09-11 22:55       ` Tian, Kevin
2014-09-11 15:38   ` Jan Beulich
2014-09-12  2:56     ` Chen, Tiejun
2014-09-12  6:19     ` Jan Beulich
2014-09-10  5:49 ` [v6][PATCH 4/7] libxc/hvm_info_table: introduce a new field nr_reserved_device_memory_map Tiejun Chen
2014-09-10 21:39   ` Tian, Kevin
2014-09-11  1:16     ` Chen, Tiejun
2014-09-10  5:49 ` [v6][PATCH 5/7] hvmloader: introduce hypercall for xc_reserved_device_memory_map Tiejun Chen
2014-09-10 21:41   ` Tian, Kevin
2014-09-11  1:32     ` Chen, Tiejun
2014-09-11  7:52     ` Jan Beulich
2014-09-11 15:45   ` Jan Beulich
2014-09-12  4:52     ` Chen, Tiejun
2014-09-10  5:49 ` [v6][PATCH 6/7] hvmloader: check to reserved device memory maps in e820 Tiejun Chen
2014-09-11 15:57   ` Jan Beulich
2014-09-12  6:08     ` Jan Beulich
2014-09-12  6:28     ` Chen, Tiejun
2014-09-12  6:44       ` Jan Beulich
2014-09-10  5:49 ` Tiejun Chen [this message]
2014-09-18  9:11   ` [v6][PATCH 7/7] xen/vtd: make USB RMRR mapping safe Jan Beulich
2014-09-10 21:44 ` [v6][PATCH 0/7] xen: reserve RMRR to avoid conflicting MMIO/RAM Tian, Kevin
2014-09-11  1:38   ` Chen, Tiejun
2014-09-11  7:48     ` Jan Beulich
2014-09-11  9:39       ` Chen, Tiejun
2014-09-11 10:01         ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1410328190-6372-8-git-send-email-tiejun.chen@intel.com \
    --to=tiejun.chen@intel.com \
    --cc=JBeulich@suse.com \
    --cc=ian.campbell@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=kevin.tian@intel.com \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=xen-devel@lists.xen.org \
    --cc=yang.z.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).