From: vijay.kilari@gmail.com
To: Ian.Campbell@citrix.com, julien.grall@linaro.org,
stefano.stabellini@eu.citrix.com, stefano.stabellini@citrix.com,
tim@xen.org, xen-devel@lists.xen.org
Cc: Prasun.Kapoor@caviumnetworks.com,
Vijaya Kumar K <Vijaya.Kumar@caviumnetworks.com>,
manish.jaggi@caviumnetworks.com, vijay.kilari@gmail.com
Subject: [PATCH for-4.5 v11 1/7] xen/arm: Calculate irq rank from irq number
Date: Fri, 12 Sep 2014 16:39:43 +0530 [thread overview]
Message-ID: <1410520189-9086-2-git-send-email-vijay.kilari@gmail.com> (raw)
In-Reply-To: <1410520189-9086-1-git-send-email-vijay.kilari@gmail.com>
From: Vijaya Kumar K <Vijaya.Kumar@caviumnetworks.com>
irq rank calculated is not generic and assumes
hardware register size value which does not work
for future GIC versions like V3.
Signed-off-by: Vijaya Kumar K <Vijaya.Kumar@caviumnetworks.com>
Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
---
xen/arch/arm/vgic.c | 21 ++++++++++++++-------
1 file changed, 14 insertions(+), 7 deletions(-)
diff --git a/xen/arch/arm/vgic.c b/xen/arch/arm/vgic.c
index 1372ffc..c6e9479 100644
--- a/xen/arch/arm/vgic.c
+++ b/xen/arch/arm/vgic.c
@@ -31,6 +31,16 @@
#include <asm/gic.h>
#include <asm/vgic.h>
+static inline struct vgic_irq_rank *vgic_get_rank(struct vcpu *v, int rank)
+{
+ if ( rank == 0 )
+ return v->arch.vgic.private_irqs;
+ else if ( rank <= DOMAIN_NR_RANKS(v->domain) )
+ return &v->domain->arch.vgic.shared_irqs[rank - 1];
+ else
+ return NULL;
+}
+
/*
* Returns rank corresponding to a GICD_<FOO><n> register for
* GICD_<FOO> with <b>-bits-per-interrupt.
@@ -40,17 +50,14 @@ struct vgic_irq_rank *vgic_rank_offset(struct vcpu *v, int b, int n,
{
int rank = REG_RANK_NR(b, (n >> s));
- if ( rank == 0 )
- return v->arch.vgic.private_irqs;
- else if ( rank <= DOMAIN_NR_RANKS(v->domain) )
- return &v->domain->arch.vgic.shared_irqs[rank - 1];
- else
- return NULL;
+ return vgic_get_rank(v, rank);
}
struct vgic_irq_rank *vgic_rank_irq(struct vcpu *v, unsigned int irq)
{
- return vgic_rank_offset(v, 8, irq, DABT_WORD);
+ int rank = irq/32;
+
+ return vgic_get_rank(v, rank);
}
int domain_vgic_init(struct domain *d)
--
1.7.9.5
next prev parent reply other threads:[~2014-09-12 11:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-12 11:09 [PATCH for-4.5 v11 0/7] xen/arm: Add GICv3 support vijay.kilari
2014-09-12 11:09 ` vijay.kilari [this message]
2014-09-12 11:09 ` [PATCH for-4.5 v11 2/7] xen/arm: Add vgic callback to read irq priority vijay.kilari
2014-09-12 18:08 ` Stefano Stabellini
2014-09-15 6:15 ` Vijay Kilari
2014-09-15 19:05 ` Stefano Stabellini
2014-09-15 22:09 ` Ian Campbell
2014-09-16 6:49 ` Vijay Kilari
2014-09-23 13:01 ` Stefano Stabellini
2014-09-23 13:09 ` Vijay Kilari
2014-09-12 11:09 ` [PATCH for-4.5 v11 3/7] xen/arm: Add support for GIC v3 vijay.kilari
2014-09-12 11:09 ` [PATCH for-4.5 v11 4/7] xen/arm: Add virtual GICv3 support vijay.kilari
2014-09-12 18:15 ` Stefano Stabellini
2014-09-12 11:09 ` [PATCH for-4.5 v11 5/7] xen/arm: Update Dom0 GIC dt node with GICv3 information vijay.kilari
2014-09-12 11:09 ` [PATCH for-4.5 v11 6/7] xen/arm: add SGI handling for GICv3 vijay.kilari
2014-09-12 11:09 ` [PATCH for-4.5 v11 7/7] xen/arm: check for GICv3 platform support vijay.kilari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1410520189-9086-2-git-send-email-vijay.kilari@gmail.com \
--to=vijay.kilari@gmail.com \
--cc=Ian.Campbell@citrix.com \
--cc=Prasun.Kapoor@caviumnetworks.com \
--cc=Vijaya.Kumar@caviumnetworks.com \
--cc=julien.grall@linaro.org \
--cc=manish.jaggi@caviumnetworks.com \
--cc=stefano.stabellini@citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).