From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH v3 4/4] xl: introduce rtds scheduler Date: Tue, 16 Sep 2014 09:49:25 +0200 Message-ID: <1410853765.20720.16.camel@Abyss> References: <1410730649-2417-1-git-send-email-mengxu@cis.upenn.edu> <1410730649-2417-5-git-send-email-mengxu@cis.upenn.edu> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7569737857769150180==" Return-path: In-Reply-To: <1410730649-2417-5-git-send-email-mengxu@cis.upenn.edu> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Meng Xu Cc: ian.campbell@citrix.com, xisisu@gmail.com, stefano.stabellini@eu.citrix.com, george.dunlap@eu.citrix.com, lu@cse.wustl.edu, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org, ptxlinh@gmail.com, xumengpanda@gmail.com, JBeulich@suse.com, chaowang@wustl.edu, lichong659@gmail.com, dgolomb@seas.upenn.edu List-Id: xen-devel@lists.xenproject.org --===============7569737857769150180== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-KwSG8QqTf4lZYlB85/Nd" --=-KwSG8QqTf4lZYlB85/Nd Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sun, 2014-09-14 at 17:37 -0400, Meng Xu wrote: > Add xl command for rtds scheduler > Note: VCPU's parameter (period, budget) is in microsecond (us). >=20 > Signed-off-by: Meng Xu > Signed-off-by: Sisu Xi > Reviewed-by: Dario Faggioli I only have two minor comments. > --- a/docs/man/xl.pod.1 > +++ b/docs/man/xl.pod.1 > +static int sched_rtds_pool_output(uint32_t poolid) > +{ > + char *poolname; > + > + poolname =3D libxl_cpupoolid_to_name(ctx, poolid); > + printf("Cpupool %s: sched=3DRTDS algorithm=3DEDF\n", poolname); > Oh, so you are printing RTDS. Perhaps the cover letter is outdated then... In any case, just use "sched=3DRTDS", no need for "algorithm=3DFOO" > + > + free(poolname); > + return 0; > +} > +int main_sched_rtds(int argc, char **argv) > +{ > + const char *dom =3D NULL; > + const char *cpupool =3D NULL; > + int period =3D 0; /* period is in microsecond */ > + int budget =3D 0; /* budget is in microsecond */ > + bool opt_p =3D false; > + bool opt_b =3D false; > + int opt, rc; > + static struct option opts[] =3D { > + {"domain", 1, 0, 'd'}, > + {"period", 1, 0, 'p'}, > + {"budget", 1, 0, 'b'}, > + {"cpupool", 1, 0, 'c'}, > + COMMON_LONG_OPTS, > + {0, 0, 0, 0} > + }; > + > + SWITCH_FOREACH_OPT(opt, "d:p:b:c:h", opts, "sched-rtds", 0) { > + case 'd': > + dom =3D optarg; > + break; > + case 'p': > + period =3D strtol(optarg, NULL, 10); > + opt_p =3D 1; > + break; > + case 'b': > + budget =3D strtol(optarg, NULL, 10); > + opt_b =3D 1; > + break; > + case 'c': > + cpupool =3D optarg; > + break; > + } > + > + if (cpupool && (dom || opt_p || opt_b)) { > + fprintf(stderr, "Specifying a cpupool is not allowed with other = options.\n"); > Long line. We probably can live with this, but since I spotted it... Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-KwSG8QqTf4lZYlB85/Nd Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEABECAAYFAlQX64UACgkQk4XaBE3IOsRMrwCeLVHygi6uYidzmbo+xwqvDjWx LA4AnjuyLB1ASs46T6JaQ06R/RkeLmLL =c+RL -----END PGP SIGNATURE----- --=-KwSG8QqTf4lZYlB85/Nd-- --===============7569737857769150180== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============7569737857769150180==--