From: Dario Faggioli <dario.faggioli@citrix.com>
To: Meng Xu <mengxu@cis.upenn.edu>
Cc: ian.campbell@citrix.com, xisisu@gmail.com,
stefano.stabellini@eu.citrix.com, george.dunlap@eu.citrix.com,
lu@cse.wustl.edu, ian.jackson@eu.citrix.com,
xen-devel@lists.xen.org, ptxlinh@gmail.com,
xumengpanda@gmail.com, JBeulich@suse.com, chaowang@wustl.edu,
lichong659@gmail.com, dgolomb@seas.upenn.edu
Subject: Re: [PATCH v3 3/4] libxl: add rtds scheduler
Date: Tue, 16 Sep 2014 10:04:05 +0200 [thread overview]
Message-ID: <1410854645.20720.22.camel@Abyss> (raw)
In-Reply-To: <1410730649-2417-4-git-send-email-mengxu@cis.upenn.edu>
[-- Attachment #1.1: Type: text/plain, Size: 1041 bytes --]
On Sun, 2014-09-14 at 17:37 -0400, Meng Xu wrote:
> Add libxl functions to set/get domain's parameters for rtds scheduler
> Note: VCPU's information (period, budget) is in microsecond (us).
>
> Signed-off-by: Meng Xu <mengxu@cis.upenn.edu>
> Signed-off-by: Sisu Xi <xisisu@gmail.com>
>
With the proper LIBXL_HAVE_XXX added:
Reviewed-by: Dario Faggioli <dario.faggioli@citrix.com>
As Ian said, look at libxl.h. You're adding a valid enum value ("rtds")
in libxl_scheduler, and a "budget" field in libxl_domain_sched_params.
I'm not sure whether I'd go for something like
#define LIBXL_HAVE_SCHED_RTDS 1
or
#define LIBXL_HAVE_SCHEDPARAMS_BUDGET 1
If it were me, I probably would have added both, but perhaps both is too
much...
Regards,
Dario
--
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2014-09-16 8:04 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-14 21:37 Introduce rtds real-time scheduler for Xen Meng Xu
2014-09-14 21:37 ` [PATCH v3 1/4] xen: add real time scheduler rtds Meng Xu
2014-09-15 10:40 ` Jan Beulich
2014-09-16 8:42 ` Dario Faggioli
2014-09-16 8:52 ` Jan Beulich
2014-09-16 8:59 ` Dario Faggioli
2014-09-16 16:38 ` Meng Xu
2014-09-17 9:22 ` Jan Beulich
2014-09-18 16:08 ` George Dunlap
2014-09-18 18:08 ` Dario Faggioli
2014-09-19 13:11 ` Meng Xu
2014-09-22 17:11 ` Dario Faggioli
2014-09-22 20:40 ` Meng Xu
2014-09-19 9:45 ` Dario Faggioli
2014-09-19 16:44 ` Konrad Rzeszutek Wilk
2014-09-22 17:26 ` Dario Faggioli
2014-09-22 20:45 ` Meng Xu
2014-09-22 22:43 ` Konrad Rzeszutek Wilk
2014-09-20 21:10 ` Meng Xu
2014-09-23 10:47 ` George Dunlap
2014-09-14 21:37 ` [PATCH v3 2/4] libxc: add rtds scheduler Meng Xu
2014-09-18 16:15 ` George Dunlap
2014-09-14 21:37 ` [PATCH v3 3/4] libxl: " Meng Xu
2014-09-15 22:07 ` Ian Campbell
2014-09-16 1:11 ` Meng Xu
2014-09-16 1:49 ` Ian Campbell
2014-09-16 3:32 ` Meng Xu
2014-09-16 7:27 ` Dario Faggioli
2014-09-16 16:54 ` Ian Campbell
2014-09-17 10:19 ` Dario Faggioli
2014-09-16 8:04 ` Dario Faggioli [this message]
2014-09-16 16:56 ` Ian Campbell
2014-09-18 16:24 ` George Dunlap
2014-09-18 17:19 ` Ian Campbell
2014-09-14 21:37 ` [PATCH v3 4/4] xl: introduce " Meng Xu
2014-09-15 22:18 ` Ian Campbell
2014-09-16 7:49 ` Dario Faggioli
2014-09-18 16:35 ` George Dunlap
2014-09-16 7:43 ` Introduce rtds real-time scheduler for Xen Dario Faggioli
2014-09-17 14:15 ` Dario Faggioli
2014-09-17 14:33 ` Meng Xu
2014-09-18 16:00 ` Meng Xu
2014-09-23 13:50 ` Ian Campbell
2014-09-24 20:59 ` Meng Xu
2014-09-24 21:14 ` Wei Liu
2014-09-25 7:39 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1410854645.20720.22.camel@Abyss \
--to=dario.faggioli@citrix.com \
--cc=JBeulich@suse.com \
--cc=chaowang@wustl.edu \
--cc=dgolomb@seas.upenn.edu \
--cc=george.dunlap@eu.citrix.com \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=lichong659@gmail.com \
--cc=lu@cse.wustl.edu \
--cc=mengxu@cis.upenn.edu \
--cc=ptxlinh@gmail.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
--cc=xisisu@gmail.com \
--cc=xumengpanda@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).