From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <dario.faggioli@citrix.com>
Subject: Re: [PATCH v3 3/4] libxl: add rtds scheduler
Date: Tue, 16 Sep 2014 10:04:05 +0200
Message-ID: <1410854645.20720.22.camel@Abyss>
References: <1410730649-2417-1-git-send-email-mengxu@cis.upenn.edu>
	<1410730649-2417-4-git-send-email-mengxu@cis.upenn.edu>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0261478373029350568=="
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1410730649-2417-4-git-send-email-mengxu@cis.upenn.edu>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Meng Xu <mengxu@cis.upenn.edu>
Cc: ian.campbell@citrix.com, xisisu@gmail.com, stefano.stabellini@eu.citrix.com, george.dunlap@eu.citrix.com, lu@cse.wustl.edu, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org, ptxlinh@gmail.com, xumengpanda@gmail.com, JBeulich@suse.com, chaowang@wustl.edu, lichong659@gmail.com, dgolomb@seas.upenn.edu
List-Id: xen-devel@lists.xenproject.org

--===============0261478373029350568==
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="=-OMbcaICFusoRzthWyuxs"

--=-OMbcaICFusoRzthWyuxs
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sun, 2014-09-14 at 17:37 -0400, Meng Xu wrote:
> Add libxl functions to set/get domain's parameters for rtds scheduler
> Note: VCPU's information (period, budget) is in microsecond (us).
>=20
> Signed-off-by: Meng Xu <mengxu@cis.upenn.edu>
> Signed-off-by: Sisu Xi <xisisu@gmail.com>
>
With the proper LIBXL_HAVE_XXX added:

Reviewed-by: Dario Faggioli <dario.faggioli@citrix.com>

As Ian said, look at libxl.h. You're adding a valid enum value ("rtds")
in libxl_scheduler, and a "budget" field in libxl_domain_sched_params.

I'm not sure whether I'd go for something like

#define LIBXL_HAVE_SCHED_RTDS 1

or

#define LIBXL_HAVE_SCHEDPARAMS_BUDGET 1

If it were me, I probably would have added both, but perhaps both is too
much...

Regards,
Dario

--=20
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


--=-OMbcaICFusoRzthWyuxs
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iEYEABECAAYFAlQX7vUACgkQk4XaBE3IOsTVAwCgrGeElyJm0ZvwAeJa2cwBde6I
3z4An2n7fjqngl4y12rfdH+0eYxrKibl
=VcS4
-----END PGP SIGNATURE-----

--=-OMbcaICFusoRzthWyuxs--


--===============0261478373029350568==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

--===============0261478373029350568==--