From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <dario.faggioli@citrix.com>
Subject: Re: [PATCH v3 1/4] xen: add real time scheduler rtds
Date: Tue, 16 Sep 2014 10:59:06 +0200
Message-ID: <1410857946.2232.1.camel@Abyss>
References: <1410730649-2417-1-git-send-email-mengxu@cis.upenn.edu>
	<1410730649-2417-2-git-send-email-mengxu@cis.upenn.edu>
	<1410856933.20720.36.camel@Abyss>
	<54181658020000780003548F@mail.emea.novell.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4409302715596423386=="
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <54181658020000780003548F@mail.emea.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: ian.campbell@citrix.com, xisisu@gmail.com, stefano.stabellini@eu.citrix.com, george.dunlap@eu.citrix.com, lu@cse.wustl.edu, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org, ptxlinh@gmail.com, xumengpanda@gmail.com, Meng Xu <mengxu@cis.upenn.edu>, chaowang@wustl.edu, lichong659@gmail.com, dgolomb@seas.upenn.edu
List-Id: xen-devel@lists.xenproject.org

--===============4409302715596423386==
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="=-GSuH1TAh1M79jMqEzvIa"

--=-GSuH1TAh1M79jMqEzvIa
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, 2014-09-16 at 09:52 +0100, Jan Beulich wrote:
> >>> On 16.09.14 at 10:42, <dario.faggioli@citrix.com> wrote:
> > On Sun, 2014-09-14 at 17:37 -0400, Meng Xu wrote:

> >> +    list_for_each_safe(iter, tmp, runq)
> >> +    {
> >> +        svc =3D __q_elem(iter);
> >> +
> >> +        if ( now >=3D svc->cur_deadline )
> >> +        {
> >> +            rt_update_deadline(now, svc);
> >> +            /* reinsert the vcpu if its deadline is updated */
> >> +            __q_remove(svc);
> >> +            __runq_insert(ops, svc);
> >> +        }
> >> +        else
> >> +            break;
> >>
> > Just from an aesthetic perspective, I think I'd have inverted the
> > condition and, hence, the two brances (i.e., "if ( < ) break; else {}")=
.
>=20
> In which case the "else" and with it one level of indentation
> should go away.
>=20
Indeed. That was the idea behind my comment in the first place and in my
mind, then, while putting that into written words, I messed up! :-/

Regards,
Dario

--=20
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


--=-GSuH1TAh1M79jMqEzvIa
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iEYEABECAAYFAlQX+9oACgkQk4XaBE3IOsQoQgCgi3rBzI38hHwU9IimAB79z7gQ
FOUAoJo8eEQKfiBKjQnGmQwXAWH24b3G
=pN4E
-----END PGP SIGNATURE-----

--=-GSuH1TAh1M79jMqEzvIa--


--===============4409302715596423386==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

--===============4409302715596423386==--