From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH] clang: sizeof(type) must not have
	__attribute__(aligned)
Date: Tue, 16 Sep 2014 19:32:19 +0100
Message-ID: <1410892339.23505.22.camel@citrix.com>
References: <533464AA.8080807@linaro.org>
	<1410633772-23044-1-git-send-email-saper@saper.info>
	<1410884486.23505.1.camel@citrix.com> <541880BC.8010201@linaro.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <Ian.Campbell@citrix.com>) id 1XTxYf-0002vK-7l
	for xen-devel@lists.xenproject.org; Tue, 16 Sep 2014 18:32:57 +0000
In-Reply-To: <541880BC.8010201@linaro.org>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Julien Grall <julien.grall@linaro.org>
Cc: xen-devel@lists.xenproject.org, Marcin Cieslak <saper@saper.info>
List-Id: xen-devel@lists.xenproject.org

On Tue, 2014-09-16 at 11:26 -0700, Julien Grall wrote:
> Hi Ian,
> 
> On 16/09/14 09:21, Ian Campbell wrote:
> > On Sat, 2014-09-13 at 18:42 +0000, Marcin Cieslak wrote:
> >
> > The commit message could go into a bit more detail as to why this is not
> > allowed. To me it sounds like clang is being overly picky, surely it can
> > just ignore the alignment in that context?
> 
> Clang will throw a warning when an attribute is unused (see 
> -Wignored-attributes). In case of libxc, we compiled with -Werror which 
> will turn this warning into an error.

Sounds to me like -Wignored-attributes is a bit pointless, perhaps we
shouldn't use it?

Ian.