From: Dario Faggioli <dario.faggioli@citrix.com>
To: Ian Campbell <ian.campbell@citrix.com>
Cc: Sisu Xi <xisisu@gmail.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
George Dunlap <george.dunlap@eu.citrix.com>,
Chenyang Lu <lu@cse.wustl.edu>,
Ian Jackson <ian.jackson@eu.citrix.com>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>,
Linh Thi Xuan Phan <ptxlinh@gmail.com>,
Meng Xu <xumengpanda@gmail.com>, Meng Xu <mengxu@cis.upenn.edu>,
Jan Beulich <JBeulich@suse.com>, Chao Wang <chaowang@wustl.edu>,
Chong Li <lichong659@gmail.com>,
Dagaen Golomb <dgolomb@seas.upenn.edu>
Subject: Re: [PATCH v3 3/4] libxl: add rtds scheduler
Date: Wed, 17 Sep 2014 12:19:57 +0200 [thread overview]
Message-ID: <1410949197.3531.113.camel@Solace.lan> (raw)
In-Reply-To: <1410886482.23505.19.camel@citrix.com>
[-- Attachment #1.1: Type: text/plain, Size: 2231 bytes --]
On mar, 2014-09-16 at 17:54 +0100, Ian Campbell wrote:
> On Tue, 2014-09-16 at 09:27 +0200, Dario Faggioli wrote:
> > On Mon, 2014-09-15 at 23:32 -0400, Meng Xu wrote:
> >
> > > 2014-09-15 21:49 GMT-04:00 Ian Campbell <ian.campbell@citrix.com>:
> >
> > > Is a 0.5hr maximum period considered to be larger than any
> > > practically
> > > useful value?
> > >
> > >
> > > I think so.
> > >
> > Yes, it is. Most of the people using this scheduler will be interested
> > in "a few [decades, hundreds] millisecond" period and budget. Someone
> > might want to try microsecs, someone may be fine with seconds.
>
> OK, so no need for me to ask if it should be a 64bit value then.
>
It actually was. Then Jan asked whether it really needed to be, and we
all agreed it did not.
TBF, what we were talking in tha thread was the xc and hv interface.
Nothing forbids the two interfaces to differ in the types of this field,
I think. I guess the question here is whether we would like, at the
libxl level, to be a bit, let's say, 'less strict'.
That would mean, e.g., using something like int64 or uint64 in libxl
(type declarations and all the related functions), and then do some
range checking, in the libxl implementation, before passing down the
values to libxc. That would be because, while libxc and Xen interface
can change, libxl should not. One possible reason could be, for example,
if we at some point will want for the budget and period to be specified
in ns, rather than us.
Honestly, I don't foresee such a thing becoming any useful, not even in
mid or long term future. It is what at least Linux sort of does (POSIX's
timespec-s are used, there), though, so it at least is worth some
thinking?
As I said already, I think this is a fine interface, even with stability
in mind, but I'd be fine with a int64_t vesion, here in libxl, if people
feels it may be better. :-)
Regards,
Dario
--
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2014-09-17 10:19 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-14 21:37 Introduce rtds real-time scheduler for Xen Meng Xu
2014-09-14 21:37 ` [PATCH v3 1/4] xen: add real time scheduler rtds Meng Xu
2014-09-15 10:40 ` Jan Beulich
2014-09-16 8:42 ` Dario Faggioli
2014-09-16 8:52 ` Jan Beulich
2014-09-16 8:59 ` Dario Faggioli
2014-09-16 16:38 ` Meng Xu
2014-09-17 9:22 ` Jan Beulich
2014-09-18 16:08 ` George Dunlap
2014-09-18 18:08 ` Dario Faggioli
2014-09-19 13:11 ` Meng Xu
2014-09-22 17:11 ` Dario Faggioli
2014-09-22 20:40 ` Meng Xu
2014-09-19 9:45 ` Dario Faggioli
2014-09-19 16:44 ` Konrad Rzeszutek Wilk
2014-09-22 17:26 ` Dario Faggioli
2014-09-22 20:45 ` Meng Xu
2014-09-22 22:43 ` Konrad Rzeszutek Wilk
2014-09-20 21:10 ` Meng Xu
2014-09-23 10:47 ` George Dunlap
2014-09-14 21:37 ` [PATCH v3 2/4] libxc: add rtds scheduler Meng Xu
2014-09-18 16:15 ` George Dunlap
2014-09-14 21:37 ` [PATCH v3 3/4] libxl: " Meng Xu
2014-09-15 22:07 ` Ian Campbell
2014-09-16 1:11 ` Meng Xu
2014-09-16 1:49 ` Ian Campbell
2014-09-16 3:32 ` Meng Xu
2014-09-16 7:27 ` Dario Faggioli
2014-09-16 16:54 ` Ian Campbell
2014-09-17 10:19 ` Dario Faggioli [this message]
2014-09-16 8:04 ` Dario Faggioli
2014-09-16 16:56 ` Ian Campbell
2014-09-18 16:24 ` George Dunlap
2014-09-18 17:19 ` Ian Campbell
2014-09-14 21:37 ` [PATCH v3 4/4] xl: introduce " Meng Xu
2014-09-15 22:18 ` Ian Campbell
2014-09-16 7:49 ` Dario Faggioli
2014-09-18 16:35 ` George Dunlap
2014-09-16 7:43 ` Introduce rtds real-time scheduler for Xen Dario Faggioli
2014-09-17 14:15 ` Dario Faggioli
2014-09-17 14:33 ` Meng Xu
2014-09-18 16:00 ` Meng Xu
2014-09-23 13:50 ` Ian Campbell
2014-09-24 20:59 ` Meng Xu
2014-09-24 21:14 ` Wei Liu
2014-09-25 7:39 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1410949197.3531.113.camel@Solace.lan \
--to=dario.faggioli@citrix.com \
--cc=JBeulich@suse.com \
--cc=chaowang@wustl.edu \
--cc=dgolomb@seas.upenn.edu \
--cc=george.dunlap@eu.citrix.com \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=lichong659@gmail.com \
--cc=lu@cse.wustl.edu \
--cc=mengxu@cis.upenn.edu \
--cc=ptxlinh@gmail.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
--cc=xisisu@gmail.com \
--cc=xumengpanda@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).