From: Dario Faggioli <dario.faggioli@citrix.com>
To: Meng Xu <mengxu@cis.upenn.edu>
Cc: ian.campbell@citrix.com, xisisu@gmail.com,
stefano.stabellini@eu.citrix.com, george.dunlap@eu.citrix.com,
lu@cse.wustl.edu, ian.jackson@eu.citrix.com,
xen-devel@lists.xen.org, ptxlinh@gmail.com,
xumengpanda@gmail.com, JBeulich@suse.com, chaowang@wustl.edu,
lichong659@gmail.com, dgolomb@seas.upenn.edu
Subject: Re: Introduce rtds real-time scheduler for Xen
Date: Wed, 17 Sep 2014 16:15:04 +0200 [thread overview]
Message-ID: <1410963304.3531.145.camel@Solace.lan> (raw)
In-Reply-To: <1410730649-2417-1-git-send-email-mengxu@cis.upenn.edu>
[-- Attachment #1.1: Type: text/plain, Size: 8872 bytes --]
On dom, 2014-09-14 at 17:37 -0400, Meng Xu wrote:
> This serie of patches adds rtds real-time scheduler to Xen.
>
I gave this series some testing, and the behavior of the scheduler is as
expected, so again, Meng and Sisu, good work.
While doing it, I've also put the series in this git repo/branch:
git://xenbits.xen.org/people/dariof/xen.git sched/rt/rtds-v3
http://xenbits.xen.org/gitweb/?p=people/dariof/xen.git;a=shortlog;h=refs/heads/sched/rt/rtds-v3
There are a couple of issue, though, one minor and one serious, which
I'd like you to fix, if possible, before freeze date. More info below.
> //list VCPUs' parameters of each domain in cpu pools using rtds scheduler
> #xl sched-rtds
> Cpupool Pool-0: sched=EDF
> Name ID Period Budget
> Domain-0 0 10000 4000
> vm1 1 10000 4000
>
So, when I boot Xen with sched=rtds, issueing this command (`xl
sched-rtds') produces a lot of printk on the serial console, basically
outputting the dump of the scheduler information.
I guess there is one call to rt_sched_dump() (or whatever that was) left
somewhere. Could you please check?
This is not a serious issue, but since you're resending anyway...
> //create a cpupool test
> #xl cpupool-cpu-remove Pool-0 3
> #xl cpupool-cpu-remove Pool-0 2
> #xl cpupool-create name=\"test\" sched=\"rtds\"
> #xl cpupool-cpu-add test 3
> #xl cpupool-cpu-add test 2
> #xl cpupool-list
> Name CPUs Sched Active Domain count
> Pool-0 2 rtds y 2
> test 2 rtds y 0
>
This works for me too.
Booting with sched=credit, creating an rtds cpupool and migruting
domains there also works here too.
However, booting with sched=rtds, and issuing the following commands:
# xl cpupool-cpu-remove Pool-0 20
# xl cpupool-cpu-remove Pool-0 21
# xl cpupool-create /etc/xen/be-cpupool
Where /etc/xen/be-cpupool looks like this:
name = "be"
sched = "credit"
cpus = ["20", "21"]
sched="credit"
Makes Xen *CRASH* with the following trace:
(XEN) ----[ Xen-4.5-unstable x86_64 debug=y Not tainted ]----
(XEN) ----[ Xen-4.5-unstable x86_64 debug=y Not tainted ]----
(XEN) CPU: 20
(XEN) CPU: 21
(XEN) RIP: e008:[<ffff82d08012bb1e>]RIP: e008:[<ffff82d08012bb1e>] check_lock+0x1e/0x3b check_lock+0x1e/0x3b
(XEN) RFLAGS: 0000000000010002
(XEN) RFLAGS: 0000000000010002 CONTEXT: hypervisor
(XEN) CONTEXT: hypervisor
(XEN) rax: 0000000000000001 rbx: 0000000000000000 rcx: 0000000000000001
(XEN) rax: 0000000000000001 rbx: 0000000000000000 rcx: 0000000000000001
(XEN) rdx: 0000000000000001 rsi: ffff830917fc4c80 rdi: 0000000000000004
(XEN) rdx: 0000000000000001 rsi: ffff830917fc2c80 rdi: 0000000000000004
(XEN) rbp: ffff830917fb7e08 rsp: ffff830917fb7e08 r8: 0000001d52034e80
(XEN) rbp: ffff830917fafe08 rsp: ffff830917fafe08 r8: 0000000000000000
(XEN) r9: ffff830828a47978 r10: 00000000deadbeef r11: 0000000000000246
(XEN) r9: ffff830917fe3ea8 r10: 00000000deadbeef r11: 0000000000000246
(XEN) r12: 0000001d51efbd89 r13: ffff82d080320de0 r14: 0000000000000000
(XEN) r12: 0000001d51efbb99 r13: ffff82d080320de0 r14: 0000000000000000
(XEN) r15: 0000000000000014 cr0: 000000008005003b cr4: 00000000000026f0
(XEN) r15: 0000000000000015 cr0: 000000008005003b cr4: 00000000000026f0
(XEN) cr3: 00000000cf08f000 cr2: 0000000000000004
(XEN) cr3: 00000000cf08f000 cr2: 0000000000000004
(XEN) ds: 002b es: 002b fs: 0000 gs: 0000 ss: e010 cs: e008
(XEN) ds: 002b es: 002b fs: 0000 gs: 0000 ss: e010 cs: e008
(XEN) Xen stack trace from rsp=ffff830917fb7e08:
(XEN) Xen stack trace from rsp=ffff830917fafe08:
(XEN) ffff830917fb7e20 ffff830917fafe20 ffff82d08012bbc4 ffff82d08012bbc4 ffff8300cf12d000 ffff8300cf12c000 ffff830917fb7eb0 ffff830917fafeb0
(XEN)
(XEN) ffff82d080128175 ffff82d080128175 ffff830917fb7e40 ffff830917fafe40 ffff82d0801879ef ffff82d0801879ef 0000001400fb7e60 0000001500fafe60
(XEN)
(XEN) ffff830917fc4060 ffff830917fc2060 ffff830917fb7e60 ffff830917fafe60 ffff830917fc4200 ffff830917fc2200 ffff830917fb7eb0 ffff830917fafeb0
(XEN)
(XEN) ffff82d08012e983 ffff82d08012e983 ffff830917fb7ef0 ffff830917fafef0 ffff82d0801aa941 ffff82d0801aa941 ffff830917fb7e90 ffff830917fafe90
(XEN)
(XEN) ffff82d0802f8980 ffff82d0802f8a00 ffff82d0802f7f80 ffff82d0802f7f80 ffffffffffffffff ffffffffffffffff ffff830917fb0000 ffff830917fa8000
(XEN)
(XEN) 00000000000f4240 00000000000f4240 ffff830917fb7ee0 ffff830917fafee0 ffff82d08012b539 ffff82d08012b539 ffff830917fb0000 ffff830917fa8000
(XEN)
(XEN) 0000001d51dfd294 0000001d51dfcb8f ffff8300cf12d000 ffff8300cf12c000 ffff83092d6a0990 ffff83092d6a0990 ffff830917fb7ef0 ffff830917fafef0
(XEN)
(XEN) ffff82d08012b591 ffff82d08012b591 ffff830917fb7f10 ffff830917faff10 ffff82d080160425 ffff82d080160425 ffff82d08012b591 ffff82d08012b591
(XEN)
(XEN) ffff8300cf12d000 ffff8300cf12c000 ffff830917fb7e10 ffff830917fafe10 0000000000000000 0000000000000000 ffff88003a0cbfd8 ffff88003a0edfd8
(XEN)
(XEN) ffff88003a0cbfd8 ffff88003a0edfd8 0000000000000007 0000000000000014 ffff88003a0cbec0 ffff88003a0edec0 0000000000000000 0000000000000000
(XEN)
(XEN) 0000000000000246 0000000000000246 0000001c6462ff88 0000001c986bebc8 0000000000000000 0000000000000000 0000000000000000 0000000000000000
(XEN)
(XEN) 0000000000000000 0000000000000000 ffffffff810013aa ffffffff810013aa ffffffff81c31160 ffffffff81c31160 00000000deadbeef 00000000deadbeef
(XEN)
(XEN) 00000000deadbeef 00000000deadbeef 0000010000000000 0000010000000000 ffffffff810013aa ffffffff810013aa 000000000000e033 000000000000e033
(XEN)
(XEN) 0000000000000246 0000000000000246 ffff88003a0cbea8 ffff88003a0edea8 000000000000e02b 000000000000e02b c2c2c2c2c2c2c2c2 c2c2c2c2c2c2c2c2
(XEN)
(XEN) c2c2c2c2c2c2c2c2 c2c2c2c2c2c2c2c2 c2c2c2c2c2c2c2c2 c2c2c2c2c2c2c2c2 c2c2c2c2c2c2c2c2 c2c2c2c2c2c2c2c2 c2c2c2c200000014 c2c2c2c200000015
(XEN)
(XEN) ffff8300cf12d000 ffff8300cf12c000 0000003897ca3280 0000003897ca1280 c2c2c2c2c2c2c2c2 c2c2c2c2c2c2c2c2
(XEN)
(XEN) Xen call trace:
(XEN) Xen call trace:
(XEN) [<ffff82d08012bb1e>] check_lock+0x1e/0x3b
(XEN) [<ffff82d08012bb1e>] check_lock+0x1e/0x3b
(XEN) [<ffff82d08012bbc4>] _spin_lock_irq+0x1b/0x6c
(XEN) [<ffff82d08012bbc4>] _spin_lock_irq+0x1b/0x6c
(XEN) [<ffff82d080128175>] schedule+0xc0/0x5da
(XEN) [<ffff82d080128175>] schedule+0xc0/0x5da
(XEN) [<ffff82d08012b539>] __do_softirq+0x81/0x8c
(XEN) [<ffff82d08012b539>] __do_softirq+0x81/0x8c
(XEN) [<ffff82d08012b591>] do_softirq+0x13/0x15
(XEN) [<ffff82d08012b591>] do_softirq+0x13/0x15
(XEN) [<ffff82d080160425>] idle_loop+0x5e/0x6e
(XEN) [<ffff82d080160425>] idle_loop+0x5e/0x6e
(XEN)
(XEN)
(XEN) Pagetable walk from 0000000000000004:
(XEN) Pagetable walk from 0000000000000004:
(XEN) L4[0x000] = 000000092d6a4063 ffffffffffffffff
(XEN) L4[0x000] = 000000092d6a4063 ffffffffffffffff
(XEN) L3[0x000] = 000000092d6a3063 ffffffffffffffff
(XEN) L3[0x000] = 000000092d6a3063 ffffffffffffffff
(XEN) L2[0x000] = 000000092d6a2063 ffffffffffffffff
(XEN) L2[0x000] = 000000092d6a2063 ffffffffffffffff
(XEN) L1[0x000] = 0000000000000000 ffffffffffffffff
(XEN) L1[0x000] = 0000000000000000 ffffffffffffffff
(XEN)
(XEN) ****************************************
(XEN) Panic on CPU 20:
(XEN) FATAL PAGE FAULT
(XEN) [error_code=0000]
(XEN) Faulting linear address: 0000000000000004
(XEN) ****************************************
(XEN)
(XEN) Manual reset required ('noreboot' specified)
(XEN)
(XEN) ****************************************
(XEN) Panic on CPU 21:
(XEN) FATAL PAGE FAULT
(XEN) [error_code=0000]
(XEN) Faulting linear address: 0000000000000004
(XEN) ****************************************
(XEN)
(XEN) Manual reset required ('noreboot' specified)
Can you please check, try to reproduce, and fix ASAP?
This, IMO, does not alter the prognosis, wrt 4.5 inclusion, at least not
per-se. In fact, it's ok for some bugs to be around at feature freeze
time, for the features we said we want. What we need to know is that
we're likely going to be able to fix them without making the release
slip.
So you should really either fix this, or provide here enough insights,
to convince people you're on the way to that. :-)
Regards,
Dario
--
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2014-09-17 14:15 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-14 21:37 Introduce rtds real-time scheduler for Xen Meng Xu
2014-09-14 21:37 ` [PATCH v3 1/4] xen: add real time scheduler rtds Meng Xu
2014-09-15 10:40 ` Jan Beulich
2014-09-16 8:42 ` Dario Faggioli
2014-09-16 8:52 ` Jan Beulich
2014-09-16 8:59 ` Dario Faggioli
2014-09-16 16:38 ` Meng Xu
2014-09-17 9:22 ` Jan Beulich
2014-09-18 16:08 ` George Dunlap
2014-09-18 18:08 ` Dario Faggioli
2014-09-19 13:11 ` Meng Xu
2014-09-22 17:11 ` Dario Faggioli
2014-09-22 20:40 ` Meng Xu
2014-09-19 9:45 ` Dario Faggioli
2014-09-19 16:44 ` Konrad Rzeszutek Wilk
2014-09-22 17:26 ` Dario Faggioli
2014-09-22 20:45 ` Meng Xu
2014-09-22 22:43 ` Konrad Rzeszutek Wilk
2014-09-20 21:10 ` Meng Xu
2014-09-23 10:47 ` George Dunlap
2014-09-14 21:37 ` [PATCH v3 2/4] libxc: add rtds scheduler Meng Xu
2014-09-18 16:15 ` George Dunlap
2014-09-14 21:37 ` [PATCH v3 3/4] libxl: " Meng Xu
2014-09-15 22:07 ` Ian Campbell
2014-09-16 1:11 ` Meng Xu
2014-09-16 1:49 ` Ian Campbell
2014-09-16 3:32 ` Meng Xu
2014-09-16 7:27 ` Dario Faggioli
2014-09-16 16:54 ` Ian Campbell
2014-09-17 10:19 ` Dario Faggioli
2014-09-16 8:04 ` Dario Faggioli
2014-09-16 16:56 ` Ian Campbell
2014-09-18 16:24 ` George Dunlap
2014-09-18 17:19 ` Ian Campbell
2014-09-14 21:37 ` [PATCH v3 4/4] xl: introduce " Meng Xu
2014-09-15 22:18 ` Ian Campbell
2014-09-16 7:49 ` Dario Faggioli
2014-09-18 16:35 ` George Dunlap
2014-09-16 7:43 ` Introduce rtds real-time scheduler for Xen Dario Faggioli
2014-09-17 14:15 ` Dario Faggioli [this message]
2014-09-17 14:33 ` Meng Xu
2014-09-18 16:00 ` Meng Xu
2014-09-23 13:50 ` Ian Campbell
2014-09-24 20:59 ` Meng Xu
2014-09-24 21:14 ` Wei Liu
2014-09-25 7:39 ` Ian Campbell
-- strict thread matches above, loose matches on Subject: below --
2014-09-20 22:16 Meng Xu
2014-09-23 13:27 ` Meng Xu
2014-09-23 13:30 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1410963304.3531.145.camel@Solace.lan \
--to=dario.faggioli@citrix.com \
--cc=JBeulich@suse.com \
--cc=chaowang@wustl.edu \
--cc=dgolomb@seas.upenn.edu \
--cc=george.dunlap@eu.citrix.com \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=lichong659@gmail.com \
--cc=lu@cse.wustl.edu \
--cc=mengxu@cis.upenn.edu \
--cc=ptxlinh@gmail.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
--cc=xisisu@gmail.com \
--cc=xumengpanda@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).