From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH 02/13] Config.mk: replace dependency to genpath with actual target Date: Thu, 18 Sep 2014 18:44:46 +0100 Message-ID: <1411062286.1920.17.camel@citrix.com> References: <1406538316-29087-1-git-send-email-olaf@aepfle.de> <1406538316-29087-3-git-send-email-olaf@aepfle.de> <20140917100207.GA18753@aepfle.de> <1410972827.23505.49.camel@citrix.com> <20140918080932.GA5049@aepfle.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20140918080932.GA5049@aepfle.de> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Olaf Hering Cc: Keir Fraser , Stefano Stabellini , Tim Deegan , Ian Jackson , xen-devel@lists.xen.org, Jan Beulich , Samuel Thibault List-Id: xen-devel@lists.xenproject.org On Thu, 2014-09-18 at 10:09 +0200, Olaf Hering wrote: > On Wed, Sep 17, Ian Campbell wrote: > > > On Wed, 2014-09-17 at 12:02 +0200, Olaf Hering wrote: > > > A question related to the change below: > > > > > > How are the make variables supposed to be changed? Right now this can be > > > done either with rerunning configure (untested by me) and by calling > > > something like 'make SBINDIR=/x/y XEN_RUN_DIR=/a/b' (used as testcase). > > > > > > I think we should arrange the code such that a new configure run is > > > required to change their value. > > > > I think we've been moving (and should be moving) in the direction of > > configuring these things via configure, so that would be ok by me. (I'm > > assuming these don't affect the hypervisor build/install, which isn't > > configure driven) > > Unfortunately, m4/paths.m4 shows that configure will change just prefix > and libdir. Other parts of config/Paths.mk.in are kind of hardcoded. > I will see how to implement a knob for at least CONFIG_DIR and INITD_DIR. I think there is an existing autoconf name for CONFIG_DIR (sysconfdir?) which I suppose we aren't properly using. Not sure how INITD_DIR is dealt with in autofoo world, I suppose the default is $sysconfdir/init.d? Does it ever get set to anything else? Ian.