From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH for 4.5 v4 1/4] xen: add real time scheduler rtds Date: Wed, 24 Sep 2014 15:41:39 +0200 Message-ID: <1411566099.4336.15.camel@Solace.lan> References: <1411251228-2093-1-git-send-email-mengxu@cis.upenn.edu> <5422D0A70200007800038343@mail.emea.novell.com> <1411564495.4336.11.camel@Solace.lan> <5422E4150200007800038454@mail.emea.novell.com> <5422C8BC.3050807@eu.citrix.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7058976813909156693==" Return-path: In-Reply-To: <5422C8BC.3050807@eu.citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: George Dunlap Cc: ian.campbell@citrix.com, xisisu@gmail.com, stefano.stabellini@eu.citrix.com, lu@cse.wustl.edu, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org, ptxlinh@gmail.com, xumengpanda@gmail.com, Meng Xu , Jan Beulich , chaowang@wustl.edu, lichong659@gmail.com, dgolomb@seas.upenn.edu List-Id: xen-devel@lists.xenproject.org --===============7058976813909156693== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-NoJQuJ7+TfLgSy3dCoYA" --=-NoJQuJ7+TfLgSy3dCoYA Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On mer, 2014-09-24 at 14:35 +0100, George Dunlap wrote: > On 09/24/2014 02:32 PM, Jan Beulich wrote: > >>>> On 24.09.14 at 15:14, wrote: > >> On mer, 2014-09-24 at 13:09 +0100, Jan Beulich wrote: > >>> Furthermore the function appears to lack serialization with other > >>> scheduler operations. > >>> > >> Not sure what you mean here. There's only one lock serializing > >> everything in this scheduler, and it's already taken when this is > >> called, the only exception being when it's called from rt_alloc_vdata(= ). > >> > >> Is it that one you're referring to? > > No. The call path do_domctl() -> sched_adjust() -> rt_dom_cntl() > > doesn't take any scheduler related locks afaics. >=20 > Indeed. >=20 Yep. So, Meng, I think all we said in this thread makes sense: - sanity checking input params in rt_dom_cntl() - serialize rt_dom_cntl() itself against the global lock - move the call to rt_update_deadline() from _alloc to _insert Probably in this priority order. :-) Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-NoJQuJ7+TfLgSy3dCoYA Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEABECAAYFAlQiyhMACgkQk4XaBE3IOsT7YgCgooCv8r9b78nwblG/oVLDCgh0 1L8AoJ+gOnI/YkKkEVJiicu3/jw1/GSA =oAmx -----END PGP SIGNATURE----- --=-NoJQuJ7+TfLgSy3dCoYA-- --===============7058976813909156693== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============7058976813909156693==--