* [PATCH] libxl: Fix build dependency for libxl.h.
@ 2014-09-24 15:30 Anthony PERARD
2014-09-25 12:44 ` Ian Campbell
2014-09-25 12:44 ` Ian Campbell
0 siblings, 2 replies; 3+ messages in thread
From: Anthony PERARD @ 2014-09-24 15:30 UTC (permalink / raw)
To: Xen Devel; +Cc: Anthony PERARD, Ian Jackson, Ian Campbell
libxl.h includes _libxl_list.h, but the Makefile does not reflect this
dependency. This can lead to build error due to a missing _libxl_list.h
file.
Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
tools/libxl/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/libxl/Makefile b/tools/libxl/Makefile
index 9d67d0b..496a269 100644
--- a/tools/libxl/Makefile
+++ b/tools/libxl/Makefile
@@ -173,7 +173,7 @@ _libxl_save_msgs_helper.h _libxl_save_msgs_callout.h: \
$(PERL) -w $< $@ >$@.new
$(call move-if-changed,$@.new,$@)
-libxl.h: _libxl_types.h
+libxl.h: _libxl_types.h _libxl_list.h
libxl_json.h: _libxl_types_json.h
libxl_internal.h: _libxl_types_internal.h _libxl_types_private.h _libxl_types_internal_private.h _paths.h
libxl_internal_json.h: _libxl_types_internal_json.h
--
Anthony PERARD
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] libxl: Fix build dependency for libxl.h.
2014-09-24 15:30 [PATCH] libxl: Fix build dependency for libxl.h Anthony PERARD
@ 2014-09-25 12:44 ` Ian Campbell
2014-09-25 12:44 ` Ian Campbell
1 sibling, 0 replies; 3+ messages in thread
From: Ian Campbell @ 2014-09-25 12:44 UTC (permalink / raw)
To: Anthony PERARD; +Cc: Ian Jackson, Xen Devel
On Wed, 2014-09-24 at 16:30 +0100, Anthony PERARD wrote:
> libxl.h includes _libxl_list.h, but the Makefile does not reflect this
> dependency. This can lead to build error due to a missing _libxl_list.h
> file.
libxl_qmp.c includes this too, is that a problem?
It's probably unnecessary since it includes libxl.h too. So maybe the
fix is to drop the #include?
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
Acked + applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] libxl: Fix build dependency for libxl.h.
2014-09-24 15:30 [PATCH] libxl: Fix build dependency for libxl.h Anthony PERARD
2014-09-25 12:44 ` Ian Campbell
@ 2014-09-25 12:44 ` Ian Campbell
1 sibling, 0 replies; 3+ messages in thread
From: Ian Campbell @ 2014-09-25 12:44 UTC (permalink / raw)
To: Anthony PERARD; +Cc: Ian Jackson, Xen Devel
On Wed, 2014-09-24 at 16:30 +0100, Anthony PERARD wrote:
> libxl.h includes _libxl_list.h, but the Makefile does not reflect this
> dependency. This can lead to build error due to a missing _libxl_list.h
> file.
libxl_qmp.c includes this too, is that a problem?
It's probably unnecessary since it includes libxl.h too. So maybe the
fix is to drop the #include?
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
Acked + applied.
> ---
> tools/libxl/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/libxl/Makefile b/tools/libxl/Makefile
> index 9d67d0b..496a269 100644
> --- a/tools/libxl/Makefile
> +++ b/tools/libxl/Makefile
> @@ -173,7 +173,7 @@ _libxl_save_msgs_helper.h _libxl_save_msgs_callout.h: \
> $(PERL) -w $< $@ >$@.new
> $(call move-if-changed,$@.new,$@)
>
> -libxl.h: _libxl_types.h
> +libxl.h: _libxl_types.h _libxl_list.h
> libxl_json.h: _libxl_types_json.h
> libxl_internal.h: _libxl_types_internal.h _libxl_types_private.h _libxl_types_internal_private.h _paths.h
> libxl_internal_json.h: _libxl_types_internal_json.h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-09-25 12:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-24 15:30 [PATCH] libxl: Fix build dependency for libxl.h Anthony PERARD
2014-09-25 12:44 ` Ian Campbell
2014-09-25 12:44 ` Ian Campbell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).