From: Daniel Kiper <daniel.kiper@oracle.com>
To: xen-devel@lists.xenproject.org
Cc: keir@xen.org, ian.campbell@citrix.com, andrew.cooper3@citrix.com,
stefano.stabellini@eu.citrix.com, ross.philipson@citrix.com,
roy.franz@linaro.org, ning.sun@intel.com, jbeulich@suse.com,
qiaowei.ren@intel.com, richard.l.maliszewski@intel.com,
gang.wei@intel.com, fu.wei@linaro.org
Subject: [PATCH v2 2/5] xen/x86: Define e820 entries counter as unsigned int
Date: Wed, 24 Sep 2014 19:19:19 +0200 [thread overview]
Message-ID: <1411579162-27503-3-git-send-email-daniel.kiper@oracle.com> (raw)
In-Reply-To: <1411579162-27503-1-git-send-email-daniel.kiper@oracle.com>
e820 entries counter is inherently an unsigned quantity
so define it as unsigned int.
Signed-off-by: Daniel Kiper <daniel.kiper@oracle.com>
---
v2 - suggestions/fixes:
- change e820 entries counter signedness
(suggested by Andrew Cooper).
---
xen/arch/x86/e820.c | 8 ++++----
xen/include/asm-x86/e820.h | 4 ++--
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/xen/arch/x86/e820.c b/xen/arch/x86/e820.c
index 55fe0d6..bf84bae 100644
--- a/xen/arch/x86/e820.c
+++ b/xen/arch/x86/e820.c
@@ -89,9 +89,9 @@ static void __init add_memory_region(unsigned long long start,
}
} /* add_memory_region */
-static void __init print_e820_memory_map(struct e820entry *map, int entries)
+static void __init print_e820_memory_map(struct e820entry *map, unsigned int entries)
{
- int i;
+ unsigned int i;
for (i = 0; i < entries; i++) {
printk(" %016Lx - %016Lx ",
@@ -512,7 +512,7 @@ static void __init reserve_dmi_region(void)
}
static void __init machine_specific_memory_setup(
- struct e820entry *raw, int *raw_nr)
+ struct e820entry *raw, unsigned int *raw_nr)
{
unsigned long mpt_limit, ro_mpt_limit;
uint64_t top_of_ram, size;
@@ -695,7 +695,7 @@ int __init reserve_e820_ram(struct e820map *e820, uint64_t s, uint64_t e)
}
unsigned long __init init_e820(
- const char *str, struct e820entry *raw, int *raw_nr)
+ const char *str, struct e820entry *raw, unsigned int *raw_nr)
{
if ( e820_verbose )
{
diff --git a/xen/include/asm-x86/e820.h b/xen/include/asm-x86/e820.h
index 71a804c..d9ff4eb 100644
--- a/xen/include/asm-x86/e820.h
+++ b/xen/include/asm-x86/e820.h
@@ -30,12 +30,12 @@ extern int e820_change_range_type(
uint32_t orig_type, uint32_t new_type);
extern int e820_add_range(
struct e820map *, uint64_t s, uint64_t e, uint32_t type);
-extern unsigned long init_e820(const char *, struct e820entry *, int *);
+extern unsigned long init_e820(const char *, struct e820entry *, unsigned int *);
extern struct e820map e820;
/* These symbols live in the boot trampoline. */
extern struct e820entry e820map[];
-extern int e820nr;
+extern unsigned int e820nr;
extern unsigned int lowmem_kb, highmem_kb;
#define e820_raw bootsym(e820map)
--
1.7.10.4
next prev parent reply other threads:[~2014-09-24 17:19 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-24 17:19 [PATCH v2 0/5] xen: Break multiboot (v1) dependency and add multiboot2 support Daniel Kiper
2014-09-24 17:19 ` [PATCH v2 1/5] xen/x86: Introduce MultiBoot Data (MBD) type Daniel Kiper
2014-09-24 18:40 ` Andrew Cooper
2014-09-25 9:22 ` Jan Beulich
2014-09-25 12:56 ` Daniel Kiper
2014-09-25 13:24 ` Jan Beulich
2014-09-25 19:24 ` Daniel Kiper
2014-09-26 8:13 ` Jan Beulich
2014-09-24 17:19 ` Daniel Kiper [this message]
2014-09-24 18:10 ` [PATCH v2 2/5] xen/x86: Define e820 entries counter as unsigned int Andrew Cooper
2014-09-24 17:19 ` [PATCH v2 3/5] xen/x86: Migrate to boot_info structure Daniel Kiper
2014-09-24 19:00 ` Andrew Cooper
2014-09-25 9:43 ` Ian Campbell
2014-09-25 12:32 ` Daniel Kiper
2014-09-24 17:19 ` [PATCH v2 4/5] xen/x86: Use constant as multiboot protocol identifier Daniel Kiper
2014-09-24 18:11 ` Andrew Cooper
2014-09-24 17:19 ` [PATCH v2 5/5] xen/x86: Add multiboot2 protocol support Daniel Kiper
2014-09-24 19:14 ` Andrew Cooper
2014-09-25 18:42 ` Daniel Kiper
2014-09-25 18:52 ` Andrew Cooper
2014-09-24 17:48 ` [PATCH v2 0/5] xen: Break multiboot (v1) dependency and add multiboot2 support Roy Franz
2014-09-25 9:15 ` Jan Beulich
2014-09-25 9:45 ` Ian Campbell
2014-09-25 13:01 ` Daniel Kiper
2014-09-25 15:56 ` Roy Franz
2014-09-25 19:47 ` Daniel Kiper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1411579162-27503-3-git-send-email-daniel.kiper@oracle.com \
--to=daniel.kiper@oracle.com \
--cc=andrew.cooper3@citrix.com \
--cc=fu.wei@linaro.org \
--cc=gang.wei@intel.com \
--cc=ian.campbell@citrix.com \
--cc=jbeulich@suse.com \
--cc=keir@xen.org \
--cc=ning.sun@intel.com \
--cc=qiaowei.ren@intel.com \
--cc=richard.l.maliszewski@intel.com \
--cc=ross.philipson@citrix.com \
--cc=roy.franz@linaro.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).