From: Daniel Kiper <daniel.kiper@oracle.com>
To: xen-devel@lists.xenproject.org
Cc: keir@xen.org, ian.campbell@citrix.com, andrew.cooper3@citrix.com,
stefano.stabellini@eu.citrix.com, ross.philipson@citrix.com,
roy.franz@linaro.org, ning.sun@intel.com, jbeulich@suse.com,
qiaowei.ren@intel.com, richard.l.maliszewski@intel.com,
gang.wei@intel.com, fu.wei@linaro.org
Subject: [PATCH v2 4/5] xen/x86: Use constant as multiboot protocol identifier
Date: Wed, 24 Sep 2014 19:19:21 +0200 [thread overview]
Message-ID: <1411579162-27503-5-git-send-email-daniel.kiper@oracle.com> (raw)
In-Reply-To: <1411579162-27503-1-git-send-email-daniel.kiper@oracle.com>
Use constant as multiboot protocol identifier instead of plain number.
Signed-off-by: Daniel Kiper <daniel.kiper@oracle.com>
---
v2 - suggestions/fixes:
- patch split rearrangement
(suggested by Andrew Cooper and Jan Beulich).
---
xen/arch/x86/boot/head.S | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xen/arch/x86/boot/head.S b/xen/arch/x86/boot/head.S
index 79bce3c..7e48833 100644
--- a/xen/arch/x86/boot/head.S
+++ b/xen/arch/x86/boot/head.S
@@ -82,7 +82,7 @@ __start:
mov %ecx,%ss
/* Check for Multiboot bootloader */
- cmp $0x2BADB002,%eax
+ cmp $MULTIBOOT_BOOTLOADER_MAGIC,%eax
jne not_multiboot
/* Set up trampoline segment 64k below EBDA */
--
1.7.10.4
next prev parent reply other threads:[~2014-09-24 17:20 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-24 17:19 [PATCH v2 0/5] xen: Break multiboot (v1) dependency and add multiboot2 support Daniel Kiper
2014-09-24 17:19 ` [PATCH v2 1/5] xen/x86: Introduce MultiBoot Data (MBD) type Daniel Kiper
2014-09-24 18:40 ` Andrew Cooper
2014-09-25 9:22 ` Jan Beulich
2014-09-25 12:56 ` Daniel Kiper
2014-09-25 13:24 ` Jan Beulich
2014-09-25 19:24 ` Daniel Kiper
2014-09-26 8:13 ` Jan Beulich
2014-09-24 17:19 ` [PATCH v2 2/5] xen/x86: Define e820 entries counter as unsigned int Daniel Kiper
2014-09-24 18:10 ` Andrew Cooper
2014-09-24 17:19 ` [PATCH v2 3/5] xen/x86: Migrate to boot_info structure Daniel Kiper
2014-09-24 19:00 ` Andrew Cooper
2014-09-25 9:43 ` Ian Campbell
2014-09-25 12:32 ` Daniel Kiper
2014-09-24 17:19 ` Daniel Kiper [this message]
2014-09-24 18:11 ` [PATCH v2 4/5] xen/x86: Use constant as multiboot protocol identifier Andrew Cooper
2014-09-24 17:19 ` [PATCH v2 5/5] xen/x86: Add multiboot2 protocol support Daniel Kiper
2014-09-24 19:14 ` Andrew Cooper
2014-09-25 18:42 ` Daniel Kiper
2014-09-25 18:52 ` Andrew Cooper
2014-09-24 17:48 ` [PATCH v2 0/5] xen: Break multiboot (v1) dependency and add multiboot2 support Roy Franz
2014-09-25 9:15 ` Jan Beulich
2014-09-25 9:45 ` Ian Campbell
2014-09-25 13:01 ` Daniel Kiper
2014-09-25 15:56 ` Roy Franz
2014-09-25 19:47 ` Daniel Kiper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1411579162-27503-5-git-send-email-daniel.kiper@oracle.com \
--to=daniel.kiper@oracle.com \
--cc=andrew.cooper3@citrix.com \
--cc=fu.wei@linaro.org \
--cc=gang.wei@intel.com \
--cc=ian.campbell@citrix.com \
--cc=jbeulich@suse.com \
--cc=keir@xen.org \
--cc=ning.sun@intel.com \
--cc=qiaowei.ren@intel.com \
--cc=richard.l.maliszewski@intel.com \
--cc=ross.philipson@citrix.com \
--cc=roy.franz@linaro.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).