From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xen.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: [PATCH for-4.5 0/2] Improve "Emulation failed" error message
Date: Fri, 26 Sep 2014 11:10:05 +0100 [thread overview]
Message-ID: <1411726207-2689-1-git-send-email-andrew.cooper3@citrix.com> (raw)
After wanting to improve this error for a long time, I have encountered two
cases in the past 2 days where I have needed more information than it
provided, so have finally gotten around to fixing it.
Patch 1 introduces a "print hex buffer" custom %p format (compatible with the
Linux equivelent), while Patch 2 improves the error message.
Konrad: I am requesting a release ack for this as it is a non-feature change
for the purpose of improving error messages. Neither of the patches are
complicated (low risk of bugs/regressions), and if the worse comes to the
worst, they can safely be reverted.
Andrew Cooper (2):
xen/vsprintf: Introduce %*ph extended format specifier for hex
buffers
x86/hvm: Improve "Emulation failed @" error messages
docs/misc/printk-formats.txt | 6 ++++++
xen/arch/x86/hvm/emulate.c | 41 +++++++++++++++++++++++++++++--------
xen/arch/x86/hvm/io.c | 11 +---------
xen/arch/x86/hvm/vmx/realmode.c | 9 +-------
xen/common/vsprintf.c | 25 ++++++++++++++++++++++
xen/include/asm-x86/hvm/emulate.h | 3 +++
6 files changed, 68 insertions(+), 27 deletions(-)
next reply other threads:[~2014-09-26 10:10 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-26 10:10 Andrew Cooper [this message]
2014-09-26 10:10 ` [PATCH for-4.5 1/2] xen/vsprintf: Introduce %*ph extended format specifier for hex buffers Andrew Cooper
2014-09-26 11:32 ` Jan Beulich
2014-09-26 12:16 ` Andrew Cooper
2014-09-26 12:31 ` Jan Beulich
2014-09-26 12:32 ` Andrew Cooper
2014-09-26 11:49 ` Tim Deegan
2014-09-26 11:57 ` Jan Beulich
2014-09-26 10:10 ` [PATCH for-4.5 2/2] x86/hvm: Improve "Emulation failed @" error messages Andrew Cooper
2014-09-26 11:39 ` Jan Beulich
2014-09-26 12:04 ` Andrew Cooper
2014-09-26 12:36 ` Jan Beulich
2014-09-26 12:53 ` Andrew Cooper
2014-09-26 12:05 ` Tim Deegan
2014-09-26 12:09 ` Andrew Cooper
2014-09-26 12:41 ` Tim Deegan
2014-09-26 12:57 ` Andrew Cooper
2014-09-26 13:06 ` Jan Beulich
2014-09-26 13:16 ` Andrew Cooper
2014-09-26 13:32 ` Jan Beulich
2014-09-26 14:15 ` [PATCH for-4.5 0/2] Improve "Emulation failed" error message Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1411726207-2689-1-git-send-email-andrew.cooper3@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).