From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xen.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: [PATCH for 4.5 v2 0/2] Improve "Emulation failed" error message
Date: Fri, 26 Sep 2014 17:24:35 +0100 [thread overview]
Message-ID: <1411748677-21069-1-git-send-email-andrew.cooper3@citrix.com> (raw)
After wanting to improve this error for a long time, I have encountered two
cases in the past 2 days where I have needed more information than it
provided, so have finally gotten around to fixing it.
Patch 1 introduces a "print hex buffer" custom %p format (compatible with the
Linux equivelent), while Patch 2 improves the error message.
Changes in v2:
* Sort position of %*ph in document. Introduce missing title for %pv.
* Clip limit at 64 bytes rather than defaulting back to 0.
* Don't emit a trailing space after the last byte of the hex buffer.
* Reduce content of message for clarity.
* Only identify 16/32/64 bit operating mode. ???_guest_x86_mode() is
currently insufficiently expressive to cover all operating modes.
Andrew Cooper (2):
xen/vsprintf: Introduce %*ph extended format specifier for hex
buffers
x86/hvm: Improve "Emulation failed @" error messages
docs/misc/printk-formats.txt | 7 +++++++
xen/arch/x86/hvm/emulate.c | 34 +++++++++++++++++++++++++---------
xen/arch/x86/hvm/io.c | 11 +----------
xen/arch/x86/hvm/vmx/realmode.c | 9 +--------
xen/common/vsprintf.c | 27 +++++++++++++++++++++++++++
xen/include/asm-x86/hvm/emulate.h | 3 +++
6 files changed, 64 insertions(+), 27 deletions(-)
--
1.7.10.4
next reply other threads:[~2014-09-26 16:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-26 16:24 Andrew Cooper [this message]
2014-09-26 16:24 ` [PATCH for 4.5 v2 1/2] xen/vsprintf: Introduce %*ph extended format specifier for hex buffers Andrew Cooper
2014-10-01 7:21 ` [PATCH v3 1/2] vsprintf: introduce " Jan Beulich
2014-10-01 8:25 ` Andrew Cooper
2014-09-26 16:24 ` [PATCH for 4.5 v2 2/2] x86/hvm: Improve "Emulation failed @" error messages Andrew Cooper
2014-09-29 8:34 ` Jan Beulich
2014-09-29 9:23 ` Andrew Cooper
2014-09-29 9:35 ` Jan Beulich
2014-09-29 9:46 ` [PATCH for 4.5 v3 " Andrew Cooper
2014-10-01 0:55 ` Tian, Kevin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1411748677-21069-1-git-send-email-andrew.cooper3@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).